From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96985 invoked by alias); 16 Jul 2015 08:32:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96921 invoked by uid 89); 16 Jul 2015 08:32:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 16 Jul 2015 08:32:21 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 7EE68344EC1; Thu, 16 Jul 2015 08:32:19 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6G8WF80024597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Jul 2015 04:32:17 -0400 Date: Thu, 16 Jul 2015 08:32:00 -0000 From: Jan Kratochvil To: Gary Benson Cc: Pedro Alves , gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v10 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Message-ID: <20150716083214.GA9940@host1.jankratochvil.net> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200454.8918.52868.stgit@host1.jankratochvil.net> <20150608083733.GA5405@blade.nx> <20150715212028.GA22133@host1.jankratochvil.net> <20150716081412.GA4954@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150716081412.GA4954@blade.nx> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00468.txt.bz2 On Thu, 16 Jul 2015 10:14:12 +0200, Gary Benson wrote: > I don't fully understand the tdep/non-tdep split very well. I understand that *-tdep.c is all of the support that makes sense for all the arch support that can be done cross-arch for loading/examining files plus all the arch support usable with remote gdbserver (cross-arch in general, with gdbserver it can be also native-arch but that does not matter). linux-maps.[ch] provides linux_find_memory_regions_full() which is used in linux-tdep.c and in gdbserver but for mostly unrelated purposes, so it is rather just a code reuse and it is not architecturally the same functionality called from both linux-nat+gdbserver just because linux-nat hasn't been dropped yet. linux-maps.[ch] also exports its read_mapping() to linux-tdep.c which is again only arbitrary code reuse from two unrelated places of code. Jan