From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105731 invoked by alias); 24 Jul 2015 10:28:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105718 invoked by uid 89); 24 Jul 2015 10:28:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Jul 2015 10:28:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 362F3461E0; Fri, 24 Jul 2015 10:28:03 +0000 (UTC) Received: from blade.nx (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6OAS2ff006796; Fri, 24 Jul 2015 06:28:02 -0400 Received: by blade.nx (Postfix, from userid 1000) id BD997264ED3; Fri, 24 Jul 2015 11:28:01 +0100 (BST) Date: Fri, 24 Jul 2015 10:28:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, =?iso-8859-1?Q?C=E9dric?= Buissart , Sandra Loosemore Subject: Re: [PATCH 4/5] Add "target:" filename handling to find_separate_debug_file Message-ID: <20150724102801.GB29978@blade.nx> References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-5-git-send-email-gbenson@redhat.com> <5593EC8E.3020603@redhat.com> <20150723143344.GA1484@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150723143344.GA1484@blade.nx> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00686.txt.bz2 Gary Benson wrote: > Pedro Alves wrote: > > On 06/16/2015 10:42 AM, Gary Benson wrote: > > > This commit updates find_separate_debug_file to handle filenames > > > prefixed with "target:". The same-directory and > > > DEBUG_SUBDIRECTORY locations are checked with the prefix if > > > supplied. The debugdir location is checked both with and without > > > the prefix if one is supplied. This makes GDB able to fetch > > > separate debug files from remote targets and from inferiors in > > > containers. > > > > > > + /* Try the same location but without TARGET_SYSROOT_PREFIX > > > + (i.e. on the local filesystem). */ > > > + debugfile = build_debug_file_name (no_prefix, debugdir, dir, > > > + debuglink, NULL); > > > > Given that we have a CRC to match, shouldn't we try the local > > filesystem first, avoiding the (potentially slow) remote fetching > > in the case the files on the container/remote are the same of the > > host's? (which I think happens often with containers). > > I think for both remote and container cases the answer to "are they > the same" is no more than "they might be". > > With containers, "target:" fetching shouldn't be very much slower > than local-filesystem fetching, just a couple more operations at > file open time. With remote it will be slower, but less likely > to be the same (maybe!) > > That was my reasoning. I can switch it round if you want though. > Let me know what you'd like... Given the slow remote transfers thread on the other list [1], I will switch it round (i.e. try locally first). Thanks, Gary -- [1] https://sourceware.org/ml/gdb/2015-07/msg00038.html