* [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets
@ 2015-07-29 22:48 Sandra Loosemore
2015-07-30 11:33 ` Yao Qi
2015-07-30 11:59 ` Jan Kratochvil
0 siblings, 2 replies; 3+ messages in thread
From: Sandra Loosemore @ 2015-07-29 22:48 UTC (permalink / raw)
To: gdb-patches; +Cc: Jan Kratochvil
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
I've found that it doesn't do anything useful to try loading a ppc64 .ko
file when testing GDB on ARM, Nios II, etc. I copied the target test
logic from the other gdb.arch/ppc64-*.exp testcase -- is this OK to
check in?
-Sandra
[-- Attachment #2: gdb-cordic.log --]
[-- Type: text/x-log, Size: 137 bytes --]
2015-07-29 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.arch/ppc64-symtab-cordic.exp: Restrict to ppc64 targets.
[-- Attachment #3: gdb-cordic.patch --]
[-- Type: text/x-patch, Size: 614 bytes --]
diff --git a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
index d9a3f13..fa82510 100644
--- a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
+++ b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
@@ -13,6 +13,11 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+if {![istarget "powerpc*"] || ![is_lp64_target]} {
+ verbose "Skipping powerpc64 separate debug file symtab test."
+ return
+}
+
standard_testfile
set kobz2file ${srcdir}/${subdir}/cordic.ko.bz2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets
2015-07-29 22:48 [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets Sandra Loosemore
@ 2015-07-30 11:33 ` Yao Qi
2015-07-30 11:59 ` Jan Kratochvil
1 sibling, 0 replies; 3+ messages in thread
From: Yao Qi @ 2015-07-30 11:33 UTC (permalink / raw)
To: Sandra Loosemore, gdb-patches; +Cc: Jan Kratochvil
On 29/07/15 23:46, Sandra Loosemore wrote:
> 2015-07-29 Sandra Loosemore<sandra@codesourcery.com>
>
> gdb/testsuite/
> * gdb.arch/ppc64-symtab-cordic.exp: Restrict to ppc64 targets.
Patch is OK to me.
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets
2015-07-29 22:48 [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets Sandra Loosemore
2015-07-30 11:33 ` Yao Qi
@ 2015-07-30 11:59 ` Jan Kratochvil
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kratochvil @ 2015-07-30 11:59 UTC (permalink / raw)
To: Sandra Loosemore; +Cc: gdb-patches
On Thu, 30 Jul 2015 00:46:02 +0200, Sandra Loosemore wrote:
> I've found that it doesn't do anything useful to try loading a ppc64 .ko
> file when testing GDB on ARM, Nios II, etc. I copied the target test logic
> from the other gdb.arch/ppc64-*.exp testcase -- is this OK to check in?
It should be rather a check for secondary target so that x86* GDB with
--enable-targets=all also runs this test. But I agree that some arch
restriction should be there so it is up to the maintainers.
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-30 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-29 22:48 [patch, testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets Sandra Loosemore
2015-07-30 11:33 ` Yao Qi
2015-07-30 11:59 ` Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).