From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [patch] signal_command: Leftover cleanup chain regression [Re: [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground]
Date: Tue, 04 Aug 2015 08:28:00 -0000 [thread overview]
Message-ID: <20150804082849.GA24816@host1.jankratochvil.net> (raw)
In-Reply-To: <1412877629-12052-5-git-send-email-palves@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
Hi,
mostly harmless but not correct.
Jan
[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 604 bytes --]
gdb/ChangeLog
2015-08-04 Jan Kratochvil <jan.kratochvil@redhat.com>
* infcmd.c (signal_command): Call do_cleanups for args_chain.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 4948d27..e4b2045 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -1264,6 +1264,8 @@ signal_command (char *signum_exp, int from_tty)
oursig = gdb_signal_from_command (num);
}
+ do_cleanups (args_chain);
+
/* Look for threads other than the current that this command ends up
resuming too (due to schedlock off), and warn if they'll get a
signal delivered. "signal 0" is used to suppress a previous
next prev parent reply other threads:[~2015-08-04 8:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 18:00 [PATCH 0/4] Fix a set of terminal/readline handling bugs/crashes Pedro Alves
2014-10-09 18:00 ` [PATCH 3/4] PR gdb/17300: Input after "c -a" crashes readline/GDB Pedro Alves
2014-10-09 18:00 ` [PATCH 1/4] Make common code handle target_terminal_* idempotency Pedro Alves
2014-10-09 18:00 ` [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground Pedro Alves
2015-08-03 21:02 ` [patch] ASAN attach crash - 7.9 regression [Re: [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground] Jan Kratochvil
2015-08-04 8:35 ` Pedro Alves
2015-08-04 11:48 ` [commit+7.10] " Jan Kratochvil
2015-08-25 15:47 ` Jan Kratochvil
2015-08-04 8:28 ` Jan Kratochvil [this message]
2015-08-04 8:37 ` [patch] signal_command: Leftover cleanup chain " Pedro Alves
2015-08-04 11:49 ` [commit+7.10] " Jan Kratochvil
2015-08-25 15:48 ` Jan Kratochvil
2014-10-09 18:00 ` [PATCH 2/4] PR gdb/17472: With annotations, input while executing in the foreground crashes readline/GDB Pedro Alves
2014-10-17 13:39 ` [pushed] Re: [PATCH 0/4] Fix a set of terminal/readline handling bugs/crashes Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804082849.GA24816@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).