From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59795 invoked by alias); 7 Aug 2015 15:20:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59786 invoked by uid 89); 7 Aug 2015 15:20:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 07 Aug 2015 15:20:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2578329B0F; Fri, 7 Aug 2015 11:20:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BQ-YeGfSNHzn; Fri, 7 Aug 2015 11:20:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 98FB129B0A; Fri, 7 Aug 2015 11:20:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2B4D946986; Fri, 7 Aug 2015 08:20:07 -0700 (PDT) Date: Fri, 07 Aug 2015 15:20:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: "Jose E. Marchesi" , gdb-patches@sourceware.org Subject: Re: [PATCH V4 5/9] New probe type: DTrace USDT probes. Message-ID: <20150807152007.GE14992@adacore.com> References: <1422874968-382-6-git-send-email-jose.marchesi@oracle.com> <87r3tp722i.fsf@redhat.com> <20150325191418.GA32233@adacore.com> <87bnjfraq1.fsf@oracle.com> <20150326175028.GA13867@adacore.com> <87y4mdjcie.fsf@oracle.com> <20150331184727.GF13867@adacore.com> <878uedey48.fsf@oracle.com> <20150806213103.GC14992@adacore.com> <87r3ngf4dq.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r3ngf4dq.fsf@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00203.txt.bz2 > Pretty nice investigation, Joel! > > This patch makes sense to me and is OK to go in (it just has a small > typo below). Thanks! Patch just pushed with the tiny correction you indicated. > Something I don't like about this goto scheme is that it doesn't contain > useful information as to why the section has been discarded ("... does > not contain valid DOF data" is too generic). But I'm just speaking my > mind here; this has nothing to do with your patch :-). We could improve it indeed. For a rainy day... -- Joel