From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51396 invoked by alias); 12 Aug 2015 20:56:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51386 invoked by uid 89); 12 Aug 2015 20:56:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Aug 2015 20:56:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D828F290A9; Wed, 12 Aug 2015 16:55:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id M3Tkkr3GLzUS; Wed, 12 Aug 2015 16:55:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A91FC290A7; Wed, 12 Aug 2015 16:55:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 00CB746993; Wed, 12 Aug 2015 13:55:56 -0700 (PDT) Date: Wed, 12 Aug 2015 20:56:00 -0000 From: Joel Brobecker To: Luis Machado Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v4 00/18] All-stop on top of non-stop Message-ID: <20150812205556.GJ22245@adacore.com> References: <1432250354-2721-1-git-send-email-palves@redhat.com> <55C4E3BD.8040801@redhat.com> <20150812183208.GA24901@adacore.com> <55CBA0D1.5000203@codesourcery.com> <20150812195948.GH22245@adacore.com> <55CBAA17.4040605@codesourcery.com> <20150812203322.GB9183@adacore.com> <55CBAF3F.7070602@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CBAF3F.7070602@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00329.txt.bz2 > I was just pointing at the fact that we already have shared library tests, > so those could be expanded to include this inter-dso call as opposed to > having a different set of tests like your patch did. But you'd need to shape > it in a way that exercises your amd64 failure mode then. Ah, OK! Speaking in general terms and for myself, I usually prefer to create new testcases rather than piggy-back on existing ones, because I find it simpler to do, and I also find it simpler to be certain that I'm not altering the older testcases in a way that some tests are no longer doing what they are supposed to do. And finally, it makes it easier to investigate regressions, because the testcase is usually simpler that way. Have you tried debugging a testcase where you have about 250 tests before the failure, and you're not sure what's relevant and what is not? ;-) -- Joel