From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119204 invoked by alias); 21 Aug 2015 16:23:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119191 invoked by uid 89); 21 Aug 2015 16:23:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Aug 2015 16:23:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 9989F67; Fri, 21 Aug 2015 16:23:23 +0000 (UTC) Received: from blade.nx (ovpn-116-91.ams2.redhat.com [10.36.116.91]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7LGNMsI016294; Fri, 21 Aug 2015 12:23:23 -0400 Received: by blade.nx (Postfix, from userid 1000) id 0C37E262FE6; Fri, 21 Aug 2015 17:23:22 +0100 (BST) Date: Fri, 21 Aug 2015 16:23:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, Andrew Burgess , Sandra Loosemore , Doug Evans , Jan Kratochvil , =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , Paul_Koning@Dell.com, Joel Brobecker Subject: [pushed] Warn when accessing binaries from remote targets Message-ID: <20150821162321.GA30784@blade.nx> References: <20150811140440.GB24095@blade.nx> <1439472239-15866-1-git-send-email-gbenson@redhat.com> <55D746B7.1010807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D746B7.1010807@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00580.txt.bz2 Pedro Alves wrote: > On 08/13/2015 02:23 PM, Gary Benson wrote: > > + if (warn_if_slow) > > + { > > + static int warning_issued = 0; > > + > > + printf_unfiltered (_("Reading %s from remote target...\n"), > > + filename); > > + > > + if (!warning_issued) > > + { > > + warning (_("File transfers from remote targets can be slow." > > + " Use \"set sysroot\" with no arguments to access" > > + " files locally instead.")); > > I wonder whether "with no arguments" is necessary here. I'd suggest > dropping that bit. It think it may even be confusing, as what the > user should do is point at a local copy of the target filesystem, > using "set sysroot /path/to/copy". The host's filesystem is not > necessarily the correct one, and often isn't. > > Otherwise this looks good to me. Pushed to master and 7.10 with that change. Thanks, Gary -- http://gbenson.net/