public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [Ada] Make string_char_type a true TYPE_CODE_CHAR type in Ada
Date: Thu, 03 Sep 2015 15:46:00 -0000	[thread overview]
Message-ID: <20150903154617.GE3356@adacore.com> (raw)
In-Reply-To: <1441275358-19855-1-git-send-email-derodat@adacore.com>

> gdb/ChangeLog:
> 
> 	* ada-lang.c (ada_language_arch_info): Create a TYPE_CODE_CHAR
> 	type instead of a TYPE_CODE_INT one for the string_char_type
> 	and the ada_primitive_type_char types.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.ada/funcall_char.exp: New testcase.
> 	* gdb.ada/funcall_char/foo.adb: New file.

Looks good to me, Pierre-Marie. Go ahead and push.

Thanks,
-- 
Joel

  reply	other threads:[~2015-09-03 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 10:16 Pierre-Marie de Rodat
2015-09-03 15:46 ` Joel Brobecker [this message]
2015-09-03 15:53   ` Pierre-Marie de Rodat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903154617.GE3356@adacore.com \
    --to=brobecker@adacore.com \
    --cc=derodat@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).