From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] Add new gdbarch method, unconditional_branch_address
Date: Fri, 18 Sep 2015 12:06:00 -0000 [thread overview]
Message-ID: <20150918120606.GC10919@embecosm.com> (raw)
In-Reply-To: <20150918120157.GB10919@embecosm.com>
* Andrew Burgess <andrew.burgess@embecosm.com> [2015-09-18 13:01:57 +0100]:
> * Kevin Buettner <kevinb@redhat.com> [2015-08-19 00:00:02 -0700]:
>
> > diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
> > index c1e2c1a..1770960 100644
> > --- a/gdb/gdbarch.h
> > +++ b/gdb/gdbarch.h
> > @@ -924,7 +924,7 @@ extern void set_gdbarch_max_insn_length (struct gdbarch *gdbarch, ULONGEST max_i
> > If your architecture doesn't need to adjust instructions before
> > single-stepping them, consider using simple_displaced_step_copy_insn
> > here.
> > -
> > +
> > If the instruction cannot execute out of line, return NULL. The
> > core falls back to stepping past the instruction in-line instead in
> > that case. */
> > @@ -1478,6 +1478,16 @@ typedef int (gdbarch_addressable_memory_unit_size_ftype) (struct gdbarch *gdbarc
> > extern int gdbarch_addressable_memory_unit_size (struct gdbarch *gdbarch);
> > extern void set_gdbarch_addressable_memory_unit_size (struct gdbarch *gdbarch, gdbarch_addressable_memory_unit_size_ftype *addressable_memory_unit_size);
> >
> > +/* Examine instruction at PC. If instruction at PC is an unconditional
> > + branch, return the address to which control is transferred when the
> > + branch is taken. Return 0 when this method is not implemented by
> > + architecture, PC refers to an invalid address, or instruction at PC
> > + is not an unconditional branch. */
> > +
> > +typedef CORE_ADDR (gdbarch_unconditional_branch_address_ftype) (struct gdbarch *gdbarch, CORE_ADDR pc);
> > +extern CORE_ADDR gdbarch_unconditional_branch_address (struct gdbarch *gdbarch, CORE_ADDR pc);
> > +extern void set_gdbarch_unconditional_branch_address (struct gdbarch *gdbarch, gdbarch_unconditional_branch_address_ftype *unconditional_branch_address);
<snip>
> How would you feel about changing the function so that it returned a
> bool and placed the address into a CORE_ADDRESS passed by pointer?
Or I could actually spot your revised patch and see you've already
done this :-/
Sorry for the noise.
Andrew
next prev parent reply other threads:[~2015-09-18 12:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 6:53 [PATCH 0/8] Break at each iteration for breakpoints placed on a while statement Kevin Buettner
2015-08-19 6:58 ` [PATCH 1/8] Add new test, gdb.base/loop-break.exp Kevin Buettner
2015-08-25 12:10 ` Pedro Alves
2015-09-18 0:50 ` Kevin Buettner
2016-02-01 20:00 ` Kevin Buettner
2016-02-15 16:51 ` Kevin Buettner
2016-02-29 16:17 ` Kevin Buettner
2015-09-22 0:11 ` Kevin Buettner
2015-08-19 7:00 ` [PATCH 2/8] Add new gdbarch method, unconditional_branch_address Kevin Buettner
2015-08-25 12:13 ` Pedro Alves
2015-09-18 1:14 ` Kevin Buettner
2015-09-18 12:02 ` Andrew Burgess
2015-09-18 12:06 ` Andrew Burgess [this message]
2015-09-18 12:26 ` Kevin Buettner
2015-09-18 12:24 ` Kevin Buettner
2015-09-22 16:09 ` Yao Qi
2015-09-22 18:03 ` Kevin Buettner
2015-08-19 7:03 ` [PATCH 3/8] Break at each iteration for breakpoints placed on a while statement Kevin Buettner
2015-08-25 12:10 ` Pedro Alves
2015-09-18 1:57 ` Kevin Buettner
2015-09-30 12:17 ` Pedro Alves
2015-10-01 1:13 ` Kevin Buettner
2015-10-01 4:09 ` Doug Evans
2015-08-19 7:06 ` [PATCH 4/8] Implement unconditional_branch_address method for x86-64 and i386 Kevin Buettner
2015-09-18 2:03 ` Kevin Buettner
2015-08-19 7:08 ` [PATCH 5/8] Implement unconditional_branch_address method for arm and thumb Kevin Buettner
2015-08-19 7:11 ` [PATCH 6/8] Implement unconditional_branch_address method for powerpc / rs6000 Kevin Buettner
2015-08-19 7:13 ` [PATCH 7/8] Implement unconditional_branch_address method for rl78 Kevin Buettner
2015-08-19 7:15 ` [PATCH 8/8] Implement unconditional_branch_address method for rx Kevin Buettner
2016-01-18 16:48 ` [PATCH 0/8] Break at each iteration for breakpoints placed on a while statement Kevin Buettner
2016-04-04 15:56 ` Yao Qi
2016-04-14 16:31 ` Luis Machado
2016-04-15 11:59 ` Yao Qi
2016-04-15 19:48 ` Kevin Buettner
2016-04-15 22:34 ` Pedro Alves
2016-04-19 16:24 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918120606.GC10919@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).