From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, dje@google.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source interleaving method
Date: Mon, 21 Sep 2015 21:48:00 -0000 [thread overview]
Message-ID: <20150921214813.GA5430@embecosm.com> (raw)
In-Reply-To: <1442847283-10200-7-git-send-email-markus.t.metzger@intel.com>
* Markus Metzger <markus.t.metzger@intel.com> [2015-09-21 16:54:43 +0200]:
> Use the new source interleaving method. We stick to the /m modifier.
> The old version is broken and there's no point in keeping it as alternative
> to this new version.
>
> /* The to_insn_history method of target record-btrace. */
> diff --git a/gdb/record.c b/gdb/record.c
> index 71ef973..c17b199 100644
> --- a/gdb/record.c
> +++ b/gdb/record.c
> @@ -458,7 +458,7 @@ get_insn_history_modifiers (char **arg)
> switch (*args)
> {
> case 'm':
> - modifiers |= DISASSEMBLY_SOURCE_DEPRECATED;
> + modifiers |= DISASSEMBLY_SOURCE;
> modifiers |= DISASSEMBLY_FILENAME;
> break;
> case 'r':
I think that we should make /s the official modifier in order to match
the disassembler modifier.
We should definitely keep /m for backwards compatibility, though I
don't have an issue with it's behaviour changing to match /s. My
concern is more about trying to keep the flags consistent as much as
possible. The change in flags would need a NEWS and manual update.
Thanks,
Andrew
next prev parent reply other threads:[~2015-09-21 21:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 14:55 [PATCH 0/6] disasm, record: fix "record instruction-history /m" Markus Metzger
2015-09-21 14:54 ` [PATCH 2/6] disasm: add struct disas_insn to describe to-be-disassembled instruction Markus Metzger
2015-10-09 12:51 ` Pedro Alves
2015-10-12 8:44 ` Metzger, Markus T
2015-10-20 11:29 ` Pedro Alves
2015-09-21 14:54 ` [PATCH 1/6] disasm: change dump_insns to print a single instruction Markus Metzger
2015-09-21 14:54 ` [PATCH 6/6] btrace: use gdb_disassembly_vec and new source interleaving method Markus Metzger
2015-09-21 21:48 ` Andrew Burgess [this message]
2015-09-22 6:18 ` Metzger, Markus T
2015-09-21 14:55 ` [PATCH 4/6] disasm: use entire line table in line_has_code_p Markus Metzger
2015-09-21 14:55 ` [PATCH 3/6] disas: add gdb_disassembly_vec Markus Metzger
2015-10-09 12:49 ` Pedro Alves
2015-10-09 13:17 ` Metzger, Markus T
2015-10-12 8:59 ` Andrew Burgess
2015-10-18 20:39 ` Doug Evans
2015-09-21 14:55 ` [PATCH 5/6] disasm: determine preceding lines independent of last_line Markus Metzger
2015-10-12 14:19 ` [PATCH 0/6] disasm, record: fix "record instruction-history /m" Metzger, Markus T
2015-10-18 21:17 ` Doug Evans
2015-10-19 9:35 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921214813.GA5430@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).