From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22818 invoked by alias); 4 Nov 2015 21:48:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22802 invoked by uid 89); 4 Nov 2015 21:48:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 04 Nov 2015 21:48:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 40D9729722; Wed, 4 Nov 2015 16:48:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id v06RQS1Oaj5z; Wed, 4 Nov 2015 16:48:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1A7C529704; Wed, 4 Nov 2015 16:48:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 95C73446B0; Wed, 4 Nov 2015 13:48:15 -0800 (PST) Date: Wed, 04 Nov 2015 21:48:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Keven Boell , gdb-patches@sourceware.org Subject: Re: off-trunk gdb.fortran/dwarf-stride.exp no longer PASSes [Re: [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support] Message-ID: <20151104214815.GR4009@adacore.com> References: <1435754532-17922-1-git-send-email-keven.boell@intel.com> <20151027212831.GA3058@host1.jankratochvil.net> <20151027212954.GA19347@host1.jankratochvil.net> <20151028161907.GB4009@adacore.com> <20151029223619.GA12147@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151029223619.GA12147@host1.jankratochvil.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-11/txt/msg00164.txt.bz2 > Apparently the VLA patchset is not yet checked-in completely, for example the > off-trunk patchset formerly contained: > > attr = dwarf2_attr (die, DW_AT_string_length, cu); > if (attr) > { > - length = DW_UNSND (attr); > + if (attr_form_is_block (attr)) > + { > > but current FSF GDB HEAD does not yet recognize attr_form_is_block for > DW_AT_string_length at all so it just cannot work yet. > > I will have to apply only remaining parts of the former off-trunk patchset but > that is sure off-topic for upstream GDB. Just to be sure - did we regress on something in the master branch? Or is this just a regression on your branch when you only rely on the changes that were made on master? The changes that were first submitted early on in the process were too big, and I suspect some of them were also OBE, so I asked that the patches be submitted piecemeal, to allow me to understand why each change was made. This allowed us to eventually get a good chunk of the work in, but as you can see, some chunks appear to still be missing... -- Joel