From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23326 invoked by alias); 9 Nov 2015 09:36:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23310 invoked by uid 89); 9 Nov 2015 09:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 09 Nov 2015 09:36:56 +0000 Received: by wmec201 with SMTP id c201so70199319wme.0 for ; Mon, 09 Nov 2015 01:36:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=veKRMLg7yCxVNFCl2UzduEB+pXbJ9kn5TcECUpsejOw=; b=Bb6CPDHsApI73NW4c3K1cWjUeSGYI0BwZgmDPpoIb3HH8iVvsW6OFwRp9+ZRo5gWCh 36ls9ORb2z4bxOJFll9St6mrpI/tr/02YXvkG0brXz1co85RzSan+KzkQ0les5sb2vi1 60woYIqkXEM8YPqoIX6mk/5LRdYWrol0l6smtUTPMgIzcQjjgadhcpVZb9HkCe+ePHud vpB6eAqmivtG0qkk2Nhrf5h6yumt58x3LdbtDEYdsmm94SMLJbzUprOLZMDIFcjRiMn3 NEm5iPPplxrNkY/CXGecaw/B5AEQq2j1WOPzcWbrSSDwR5v865iJqA/va5bvBcQi2MXV NCsw== X-Gm-Message-State: ALoCoQnLcAmokwz3gB6Dm1mJxiIGyW2XWtjAo6WHcF1YEHIfABDScW7HKJPxZVUzmoqXnTIjpFKe X-Received: by 10.28.11.13 with SMTP id 13mr23931869wml.4.1447061813187; Mon, 09 Nov 2015 01:36:53 -0800 (PST) Received: from localhost (host81-131-205-73.range81-131.btcentralplus.com. [81.131.205.73]) by smtp.gmail.com with ESMTPSA id 71sm13248555wmm.24.2015.11.09.01.36.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Nov 2015 01:36:52 -0800 (PST) Date: Mon, 09 Nov 2015 09:36:00 -0000 From: Andrew Burgess To: Fei Jie Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/4] Add testcases to break.exp Message-ID: <20151109093650.GA22241@embecosm.com> References: <1447057215-7574-1-git-send-email-feij.fnst@cn.fujitsu.com> <1447057215-7574-5-git-send-email-feij.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447057215-7574-5-git-send-email-feij.fnst@cn.fujitsu.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00222.txt.bz2 * Fei Jie [2015-11-09 16:20:15 +0800]: > add testcases to break.exp as follows: > *break with non-existed condition > *break with out-ou-ranged address > *break at offset -1 > > gdb/testsuite/ChangeLog: > > * gdb.base/break.exp: Add new testcases. > --- > gdb/testsuite/gdb.base/break.exp | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp > index f879bc8..5178773 100644 > --- a/gdb/testsuite/gdb.base/break.exp > +++ b/gdb/testsuite/gdb.base/break.exp > @@ -334,6 +334,11 @@ gdb_test "enable" "" "" > gdb_test "disable 10" "No breakpoint number 10." \ > "disable non-existent breakpoint 10" > > +gdb_test "break main if donot_exist == 0" \ > + "No symbol \"donot_exist\" in current context\\." > +gdb_test "break \*0xfffffffffffffffff" \ > + "Numeric constant too large\\." > + > gdb_test_no_output "set \$baz = 1.234" > gdb_test "disable \$baz" \ > "Convenience variable must have integer value.*" \ > @@ -399,6 +404,10 @@ set bp_location10 [gdb_get_line_number "set breakpoint 10 here"] > gdb_test "break +1" \ > "Breakpoint.*at.* file .*$srcfile, line $bp_location10\\." \ > "breakpoint offset +1" > +# Test break at offset -1. > +gdb_test "break -1" \ > + "Note: breakpoint 6 also set at.*Breakpoint.*at.* file .*$srcfile, line.*" \ > + "breakpoint offset -1" You can't rely on the previous breakpoint being number 6. Some of the different target types place breakpoints during start up and so the breakpoint number will be different. This is why non of the other tests hard code the breakpoint numbers in the expected output. You should either just regexp out the breakpoint number, or, capture the breakpoint number earlier and use that in the expected output, usually just using a regexp is sufficient. Thanks, Andrew