From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7291 invoked by alias); 23 Nov 2015 18:06:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7273 invoked by uid 89); 23 Nov 2015 18:06:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Nov 2015 18:06:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 43269116767; Mon, 23 Nov 2015 13:06:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ISPxjUrY78BK; Mon, 23 Nov 2015 13:06:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1269E1166F3; Mon, 23 Nov 2015 13:06:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9F4EB405C1; Mon, 23 Nov 2015 10:06:46 -0800 (PST) Date: Mon, 23 Nov 2015 18:06:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] error/internal-error printing local variable during "bt full". Message-ID: <20151123180646.GF3377@adacore.com> References: <1447093747-21709-1-git-send-email-brobecker@adacore.com> <564F4851.4070102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564F4851.4070102@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-11/txt/msg00489.txt.bz2 > > gdb/ChangeLog: > > > > * stack.c (print_frame_local_vars): Temporarily set the selected > > frame to FRAME while printing the frame's local variables. [...] > LGTM. Thanks, Pedro. The patch has now been pushed. > > Thinking longer term, I think the best approach is to add a "frame" > > parameter to value_at_lazy, and make sure it gets passed down all > > the way to the type resolver. But the number of locations that this > > change impacts is quite large, so I just wanted to receive the OK from > > the rest of the group before embarking on such a large change, knowing > > that once done, the patch would ideally be pushed quickly to avoid > > having to handle rebasing conflicts. > > In general (haven't looked at the locations this particular case involves), > I've wondered before about adding some "struct execution_context" or some > such, which would encapsulate frame, thread, target, language, etc., > and pass around a pointer to such a thing. I think it might make sense. There are a number of places where it would be beneficial to access that info through such a struct, rather than through the global context... I'll stew on it for a while... -- Joel