public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Fei Jie <feij.fnst@cn.fujitsu.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/4] Add testcases to default.exp
Date: Sun, 06 Dec 2015 13:51:00 -0000	[thread overview]
Message-ID: <20151206135130.GD10969@adacore.com> (raw)
In-Reply-To: <1447142188-20759-2-git-send-email-feij.fnst@cn.fujitsu.com>

>     add testcases about info:
>     *info extensions
>     *info handle
>     *info scope
>     *info win
>     add testcases about set width:
>     *set width -1

Just a couple of minor nits:

  1. "testcases" -> "tests"; the .exp file (Eg. default.exp) is
     a testcase, while a call to gdb_test executed a test. The testcase
     is a collection of tests usually logically related.

  2. We follow the GNU Coding Standards.
     https://sourceware.org/gdb/wiki/Internals%20Coding-Standards

     Above, sentences should start with a capital letter and end
     with a period (or a colon, as is more appropriate in your case).
     Therefore, start at the start of the line (no identation), and
     write "Add" instead of "add".

> gdb/testsuite/ChangeLog:
> 
>     * gdb.base/default.exp: Add new testcases.

Same as above, "testcases" -> "tests".

>  gdb/testsuite/gdb.base/default.exp | 10 ++++++++++
>  1 file changed, 10 insertions(+)

The changes themselves look good to me.

IIRC, I sent you the form to get started on copyright assignement,
so we'll need those to get through before we can accept your
contribution.

Thank you,
-- 
Joel

  reply	other threads:[~2015-12-06 13:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10  7:56 [PATCH v3 0/4] Add some testcases Fei Jie
2015-11-10  7:57 ` [PATCH v3 4/4] Add testcases to break.exp Fei Jie
2015-12-06 14:10   ` Joel Brobecker
2015-11-10  7:57 ` [PATCH v3 3/4] Add testcases to list.exp and dfp-test.exp Fei Jie
2015-12-06 14:08   ` Joel Brobecker
2015-11-10  7:57 ` [PATCH v3 2/4] Add testcases to display.exp Fei Jie
2015-12-06 14:00   ` Joel Brobecker
2015-11-10  7:57 ` [PATCH v3 1/4] Add testcases to default.exp Fei Jie
2015-12-06 13:51   ` Joel Brobecker [this message]
2015-11-10  8:02 ` [PATCH v3 0/4] Add some testcases fj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151206135130.GD10969@adacore.com \
    --to=brobecker@adacore.com \
    --cc=feij.fnst@cn.fujitsu.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).