From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27058 invoked by alias); 6 Dec 2015 14:10:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27036 invoked by uid 89); 6 Dec 2015 14:10:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 06 Dec 2015 14:10:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 89CF11165DB; Sun, 6 Dec 2015 09:10:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VZRIyYLCCgLO; Sun, 6 Dec 2015 09:10:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5C36E1165C1; Sun, 6 Dec 2015 09:10:38 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EF5B2445B6; Sun, 6 Dec 2015 15:10:36 +0100 (CET) Date: Sun, 06 Dec 2015 14:10:00 -0000 From: Joel Brobecker To: Fei Jie Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/4] Add testcases to break.exp Message-ID: <20151206141036.GG10969@adacore.com> References: <1447142188-20759-1-git-send-email-feij.fnst@cn.fujitsu.com> <1447142188-20759-5-git-send-email-feij.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447142188-20759-5-git-send-email-feij.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-12/txt/msg00115.txt.bz2 > add testcases to break.exp as follows: > *break with non-existed condition > *break with out-ou-ranged address > *break at offset -1 > > gdb/testsuite/ChangeLog: > > * gdb.base/break.exp: Add new testcases. Same comments as before... The changes themselves look OK to me. -- Joel