public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][RX] instructions test set.
Date: Fri, 25 Dec 2015 17:04:00 -0000	[thread overview]
Message-ID: <20151225170415.GT25803@vapier.lan> (raw)
In-Reply-To: <1451053193-27204-2-git-send-email-ysato@users.sourceforge.jp>

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On 25 Dec 2015 23:19, Yoshinori Sato wrote:
> --- /dev/null
> +++ b/sim/testsuite/sim/rx/abs.s
> @@ -0,0 +1,25 @@
> +# RX testcase for abs
> +# mach:	all

i think you want to use "rx rxv2" instead of "all"

> --- /dev/null
> +++ b/sim/testsuite/sim/rx/allinsn.exp
> @@ -0,0 +1,67 @@
> +# Renesas RX simulator testsuite
> +
> +set all "rx rxv2"
> +set global_ld_options "-Ttext=0x01000000 --defsym __stack=0x01800000"

move these inside of the "if" statement

> +if [istarget rx-*-*] then {

drop the "then" keyword

> +    run_sim_test abs.s  $all

instead of listing them all out, look at how testsuite/sim/msp430/allinsn.exp
is written using a loop and glob.  i think passing down $all for all of the
tests should be fine, even the later ones where you pass rxv2.  the framework
should skip things as needed.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-12-25 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25 14:20 [PATCH][RX] v2 instructions support Yoshinori Sato
2015-12-25 14:20 ` [PATCH][RX] instructions test set Yoshinori Sato
2015-12-25 17:04   ` Mike Frysinger [this message]
2015-12-25 16:57 ` [PATCH][RX] v2 instructions support Mike Frysinger
2015-12-27  8:51 Yoshinori Sato
2015-12-27  8:51 ` [PATCH][RX] instructions test set Yoshinori Sato
2015-12-27 21:56   ` Mike Frysinger
2015-12-28 12:37 Yoshinori Sato
2015-12-28 17:28 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151225170415.GT25803@vapier.lan \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).