From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87708 invoked by alias); 1 Jan 2016 09:48:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87691 invoked by uid 89); 1 Jan 2016 09:48:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=UD:mi-vla-fortran.exp, sk:mi-vla-, sk:mivla, behaving X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 01 Jan 2016 09:48:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 35D2D116652; Fri, 1 Jan 2016 04:48:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MPWGb+eOHp+Y; Fri, 1 Jan 2016 04:48:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C7BBF116648; Fri, 1 Jan 2016 04:48:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DCFED43C4D; Fri, 1 Jan 2016 13:48:50 +0400 (RET) Date: Fri, 01 Jan 2016 09:48:00 -0000 From: Joel Brobecker To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: Set max-value-size before running tests. Message-ID: <20160101094850.GD12416@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-01/txt/msg00004.txt.bz2 > Setting the max-value-size before running any tests should prevent any > issues where a failing test causes gdb to bring down the testing > machine. > > The maximum size is set to 1G, this is large enough to handle all the > well behaving tests, and should make no difference to the test results. > > There is one test, gdb.mi/mi-vla-fortran.exp that contains undefined > behaviour, one some machines this test is known to trigger the I suggest changing "behavior," to "behavior;". Also "one some" -> "on some". > max-value-size error. However, on those machines the test would have > failed anyway, so this commit does not change the PASS / FAIL nature of > the test. A later commit should modify the mi-vla-fortran.exp test to > expect the failure case. > > gdb/testsuite/ChangeLog: > > * lib/gdb.exp (default_gdb_start): Set max-value-size. > * lib/mi-support.exp (default_mi_gdb_start): Likewise. > * gdb.base/max-value-size.exp: Don't check the initial value. Looks good. This patch is approved to go in after patch #1 is approved. Thank you, -- Joel