From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92635 invoked by alias); 1 Jan 2016 09:53:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92624 invoked by uid 89); 1 Jan 2016 09:53:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=UD:mi-vla-fortran.exp, sk:mi-vla-, sk:mivla, H*MI:sk:2016010 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 01 Jan 2016 09:53:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8086D116652; Fri, 1 Jan 2016 04:52:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Jcz8CWugCO9o; Fri, 1 Jan 2016 04:52:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1CDB1116648; Fri, 1 Jan 2016 04:52:58 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 32C7943C4D; Fri, 1 Jan 2016 13:52:54 +0400 (RET) Date: Fri, 01 Jan 2016 09:53:00 -0000 From: Joel Brobecker To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: Set max-value-size before running tests. Message-ID: <20160101095254.GA3697@adacore.com> References: <20160101094850.GD12416@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160101094850.GD12416@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-01/txt/msg00005.txt.bz2 > > Setting the max-value-size before running any tests should prevent any > > issues where a failing test causes gdb to bring down the testing > > machine. > > > > The maximum size is set to 1G, this is large enough to handle all the > > well behaving tests, and should make no difference to the test results. > > > > There is one test, gdb.mi/mi-vla-fortran.exp that contains undefined > > behaviour, one some machines this test is known to trigger the > > I suggest changing "behavior," to "behavior;". > Also "one some" -> "on some". > > > max-value-size error. However, on those machines the test would have > > failed anyway, so this commit does not change the PASS / FAIL nature of > > the test. A later commit should modify the mi-vla-fortran.exp test to > > expect the failure case. > > > > gdb/testsuite/ChangeLog: > > > > * lib/gdb.exp (default_gdb_start): Set max-value-size. > > * lib/mi-support.exp (default_mi_gdb_start): Likewise. > > * gdb.base/max-value-size.exp: Don't check the initial value. > > Looks good. This patch is approved to go in after patch #1 is > approved. Actually, I take that back!!! I just realized that this only makes sense if we left the default to unlimited, but as you saw in my previous message, this is not the case. So I think we should simply drop the lib/ part of the patch and just keep the gdb.base/max-value-size.exp part. We'll the wait and see if any test triggers an unexpected failure on some platforms, but those would be. But, my guess is that those unexpected failures might actually be indicative of a real issue ;-). Thanks, and sorry for the confusion! -- Joel