From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37227 invoked by alias); 5 Jan 2016 14:14:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37169 invoked by uid 89); 5 Jan 2016 14:14:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=UD:mi-vla-fortran.exp, sk:mi-vla-, sk:mivla, back!!! X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 05 Jan 2016 14:14:21 +0000 Received: by mail-wm0-f48.google.com with SMTP id f206so24609916wmf.0 for ; Tue, 05 Jan 2016 06:14:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=yDCeAzE2hisvQQHiGr4O3BSfEdBy+xHvG1SbTg2PNc4=; b=TRDbaKOO/KhAP6siUe89Uqrej2K1iqVmDOen4Ul1rFnXeLqGUG6+FYwObMNgaEDWUY DFWBd7FJb2czXA/4YVLGoYHpobt4pF5Hbv2UPngPo68xwsdUwRIXj9Su2gCoMmycikhX 6+mKkgfe4luafG+LQtOiATcYoF+qqz5F6kgMMF7BQDDQ1jwo2NC1nSBJ6K9voXuEnod5 dTYgM9gmb+HZM4LeHXtG4vkVshhKUVVVsDFG/k8IYXUMkJuN0pG8YjiNXXC7OMjcwSyu VfiUuIW+USSWfNafvtDYIpMYz7JPzrfmrTC64kYcTID3F4p4Q3TqkU7m4nSzub/O9G48 UgdQ== X-Gm-Message-State: ALoCoQn5rxTfafL9vJQDlRDREi/nr7uEN2yIazP1WfyAbmjMzFg6KbxVMs7EG1jVTvR3fMyPzMlMSHV1eCyuknq4Onr/hhNtZw== X-Received: by 10.194.103.164 with SMTP id fx4mr82971798wjb.56.1452003258621; Tue, 05 Jan 2016 06:14:18 -0800 (PST) Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id jm4sm90975661wjb.7.2016.01.05.06.14.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2016 06:14:17 -0800 (PST) Date: Tue, 05 Jan 2016 14:14:00 -0000 From: Andrew Burgess To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: Set max-value-size before running tests. Message-ID: <20160105141417.GH4242@embecosm.com> References: <20160101094850.GD12416@adacore.com> <20160101095254.GA3697@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160101095254.GA3697@adacore.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00052.txt.bz2 * Joel Brobecker [2016-01-01 13:52:54 +0400]: > > > Setting the max-value-size before running any tests should prevent any > > > issues where a failing test causes gdb to bring down the testing > > > machine. > > > > > > The maximum size is set to 1G, this is large enough to handle all the > > > well behaving tests, and should make no difference to the test results. > > > > > > There is one test, gdb.mi/mi-vla-fortran.exp that contains undefined > > > behaviour, one some machines this test is known to trigger the > > > > I suggest changing "behavior," to "behavior;". > > Also "one some" -> "on some". > > > > > max-value-size error. However, on those machines the test would have > > > failed anyway, so this commit does not change the PASS / FAIL nature of > > > the test. A later commit should modify the mi-vla-fortran.exp test to > > > expect the failure case. > > > > > > gdb/testsuite/ChangeLog: > > > > > > * lib/gdb.exp (default_gdb_start): Set max-value-size. > > > * lib/mi-support.exp (default_mi_gdb_start): Likewise. > > > * gdb.base/max-value-size.exp: Don't check the initial value. > > > > Looks good. This patch is approved to go in after patch #1 is > > approved. > > Actually, I take that back!!! > > I just realized that this only makes sense if we left the default to > unlimited, but as you saw in my previous message, this is not the case. > So I think we should simply drop the lib/ part of the patch and > just keep the gdb.base/max-value-size.exp part. We'll the wait and > see if any test triggers an unexpected failure on some platforms, > but those would be. But, my guess is that those unexpected failures > might actually be indicative of a real issue ;-). > > Thanks, and sorry for the confusion! No problem. With the default now being set in patch #1, the *.exp changes naturally move there too. As a result this patch is now empty. I've applied it as obvious ;-) Thanks, Andrew