From: Mike Frysinger <vapier@gentoo.org>
To: Andrew Bennett <Andrew.Bennett@imgtec.com>
Cc: Maciej Rozycki <Maciej.Rozycki@imgtec.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Steve Ellcey <Steve.Ellcey@imgtec.com>
Subject: Re: [PATCH] Add micromips support to the MIPS simulator
Date: Fri, 15 Jan 2016 17:45:00 -0000 [thread overview]
Message-ID: <20160115174453.GA4894@vapier.lan> (raw)
In-Reply-To: <0DA23CC379F5F945ACB41CF394B9827761B7E470@LEMAIL01.le.imgtec.org>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On 15 Jan 2016 16:22, Andrew Bennett wrote:
> > As a microMIPS engine is not included in a mips-linux-gnu build the file
> > supposed to provide `micromips_instruction_decode' is not generated or
> > compiled, whereas `delayslot_micromips' (and a bunch of other functions)
> > is built unconditionally.
> >
> > Restricting the affected functions to microMIPS processors only has fixed
> > the build problem for me, see the patch below. I have not verified it
> > further though, will you be able to look into it soon?
>
> Hi Maciej,
>
> The patch looks good, I noticed that the FMT_MICROMIPS, FMT_MICROMIPS_CVT_D
> and FMT_MICROMIPS_CVT_S functions also needed fixing. I have built it for the
> mips-elf, mips-linux-gnu and mips-mti-elf targets and they all build successfully.
> The updated patch and ChangeLog is below.
>
> Ok to commit?
looks fine to me. note that this is PR sim/19441 (which is assigned
to you), so you should note that in the ChangeLog/commit message.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-15 17:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 12:44 Andrew Bennett
2015-02-24 5:44 ` Mike Frysinger
2015-08-27 15:05 ` Andrew Bennett
2015-09-11 10:24 ` Andrew Bennett
2016-01-01 7:07 ` Joel Brobecker
2016-01-05 14:40 ` Andrew Bennett
2016-01-06 5:43 ` Joel Brobecker
2015-09-17 4:42 ` Mike Frysinger
2015-09-25 12:06 ` Andrew Bennett
2015-09-25 14:07 ` Mike Frysinger
2015-09-25 20:22 ` Andrew Bennett
2015-09-25 20:57 ` Mike Frysinger
2016-01-12 23:01 ` Maciej W. Rozycki
2016-01-15 16:22 ` Andrew Bennett
2016-01-15 17:45 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115174453.GA4894@vapier.lan \
--to=vapier@gentoo.org \
--cc=Andrew.Bennett@imgtec.com \
--cc=Maciej.Rozycki@imgtec.com \
--cc=Steve.Ellcey@imgtec.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).