From: Joel Brobecker <brobecker@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches
Date: Thu, 21 Jan 2016 10:33:00 -0000 [thread overview]
Message-ID: <20160121103321.GD5146@adacore.com> (raw)
In-Reply-To: <569D591C.5000509@redhat.com>
> On 01/17/2016 07:32 AM, Joel Brobecker wrote:
> > What do you think of the attached patch? There is also a testcase,
> > which is slightly different from the scenario that triggered this
> > exchange, but which also has the advantage of not requiring PIE,
> > which makes the test a little more universal, I think.
>
> This looks great to me. I say go for it.
>
> [Wow, you found a non-PIE reproducer. Way cool!]
:-). thanks for the review, Keith. I just pushed the patch.
> PS. I also note there was a "save breakpoints" bug related to this bug,
> too. I'll work on a separate submission for that. This is definitely
> should have some test coverage!
That would be nice indeed.
--
Joel
next prev parent reply other threads:[~2016-01-21 10:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 23:28 [PATCH v6 0/9] Series short description Keith Seitz
2015-08-05 23:29 ` [PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-08-10 17:34 ` Doug Evans
2015-08-10 18:05 ` Keith Seitz
2015-08-10 19:59 ` Doug Evans
2015-08-11 20:45 ` [PATCH v6 2/9] Explicit locations: introduce new struct event_locations-based API Keith Seitz
2015-08-11 21:49 ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 3/9] Explicit locations: use new location API Keith Seitz
2015-08-10 18:02 ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-08-10 16:43 ` Doug Evans
2015-08-05 23:30 ` [PATCH v6 4/9] Explicit locations: introduce address locations Keith Seitz
2015-08-10 18:04 ` Doug Evans
2015-12-14 7:11 ` Joel Brobecker
2015-12-14 20:56 ` Keith Seitz
2015-12-15 13:40 ` Joel Brobecker
2016-01-17 15:32 ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches (was: "Re: [PATCH v6 4/9] Explicit locations: introduce address locations") Joel Brobecker
2016-01-18 21:29 ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches Keith Seitz
2016-01-21 10:33 ` Joel Brobecker [this message]
2015-08-05 23:30 ` [PATCH v6 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-08-10 18:06 ` Doug Evans
2015-08-05 23:32 ` [PATCH v6 6/9] Explicit locations: introduce explicit locations Keith Seitz
2015-08-10 18:09 ` Doug Evans
2015-08-05 23:33 ` [PATCH v6 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-08-10 19:42 ` Doug Evans
2015-08-11 20:45 ` Keith Seitz
2015-08-11 21:50 ` Doug Evans
2015-08-17 16:41 ` Yao Qi
2015-08-17 17:19 ` Keith Seitz
2015-08-05 23:33 ` [PATCH v6 8/9] Explicit locations: MI support for explicit locations Keith Seitz
2015-08-10 19:43 ` Doug Evans
2015-08-05 23:34 ` [PATCH v6 9/9] Explicit locations: documentation updates Keith Seitz
2015-08-10 19:45 ` Doug Evans
2015-08-10 19:54 ` [PATCH v6 0/9] Series short description Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121103321.GD5146@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).