From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] rx: Treat scalars larger than 8 bytes as aggregates in rx_push_dummy_call
Date: Tue, 26 Jan 2016 12:39:00 -0000 [thread overview]
Message-ID: <20160126123938.GK5146@adacore.com> (raw)
In-Reply-To: <20160123161811.1c92dd3d@pinnacle.lan>
Hi Kevin,
> gdb/ChangeLog:
>
> * rx-tdep.c (rx_push_dummy_call): Treat scalars larger than 8
> bytes as aggregates.
I'll trust you on RX matters, and the contents of the message
seems to indicate that you would have tested the change using
our testsuite, so...
OK with me! :-)
> ---
> gdb/rx-tdep.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/rx-tdep.c b/gdb/rx-tdep.c
> index 2732608..904aebd 100644
> --- a/gdb/rx-tdep.c
> +++ b/gdb/rx-tdep.c
> @@ -813,7 +813,8 @@ rx_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
> struct_addr);
> }
> else if (TYPE_CODE (arg_type) != TYPE_CODE_STRUCT
> - && TYPE_CODE (arg_type) != TYPE_CODE_UNION)
> + && TYPE_CODE (arg_type) != TYPE_CODE_UNION
> + && arg_size <= 8)
> {
> /* Argument is a scalar. */
> if (arg_size == 8)
--
Joel
next prev parent reply other threads:[~2016-01-26 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 23:18 Kevin Buettner
2016-01-26 12:39 ` Joel Brobecker [this message]
2016-01-27 19:37 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126123938.GK5146@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).