From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
brobecker@adacore.com, gdb-patches@sourceware.org,
Pedro Alves <palves@redhat.com>
Subject: Re: [testsuite patch] testsuite regression: gdb.fortran/vla-value-sub.exp gdb.fortran/vla-value-sub-finish.exp [Re: [PATCH 1/3] gdb: New set/show max-value-size command.]
Date: Sun, 14 Feb 2016 00:51:00 -0000 [thread overview]
Message-ID: <20160214005108.GE4770@embecosm.com> (raw)
In-Reply-To: <20160213214046.GA17145@host1.jankratochvil.net>
* Jan Kratochvil <jan.kratochvil@redhat.com> [2016-02-13 22:40:46 +0100]:
> On Wed, 06 Jan 2016 12:40:50 +0100, Andrew Burgess wrote:
> > +static int max_value_size = 65536; /* 64k bytes */
>
> FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array)
> FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was mofified in debugger (passed fixed array)
> FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was filled
> FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was mofified in debugger
>
> print array2
> value requires 296352 bytes, which is more than max-value-size
> (gdb) FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array)
>
> OK for check-in?
Not a maintainer, but this looks fine to me.
Apologies for not spotting the breakage, this error triggered so often
in the fortran tests I admit I got a bit lazy and assumed they were
all legitimate.
Thanks for tracking these down,
Andrew
>
> Tested on x86_64-fedora23-linux-gnu.
>
>
> Jan
> gdb/testsuite/ChangeLog
> 2016-02-13 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.fortran/vla-value-sub-finish.exp (set max-value-size 1024*1024):
> New test.
> * gdb.fortran/vla-value-sub.exp: Likewise.
>
> diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> index c47ef2c..fde6c9f 100644
> --- a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> @@ -32,6 +32,8 @@ if ![runto_main] {
>
> gdb_breakpoint [gdb_get_line_number "array2-almost-filled"]
> gdb_continue_to_breakpoint "array2-almost-filled"
> +# array2 size is 296352 bytes.
> +gdb_test_no_output "set max-value-size 1024*1024"
> gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \
> "print array2 in foo after it was filled"
> gdb_test "print array2(2,1,1)=20" " = 20" \
> diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub.exp b/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> index 361d7a9..179683d 100644
> --- a/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> @@ -42,6 +42,8 @@ gdb_test "print array1(1, 1)" " = 30" \
>
> gdb_breakpoint [gdb_get_line_number "array2-almost-filled"]
> gdb_continue_to_breakpoint "array2-almost-filled (1st)"
> +# array2 size is 296352 bytes.
> +gdb_test_no_output "set max-value-size 1024*1024"
> gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \
> "print array2 in foo after it was filled (passed fixed array)"
> gdb_test "print array2(2,1,1)=20" " = 20" \
next prev parent reply other threads:[~2016-02-14 0:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 21:38 [PATCH 0/2] Problems with gdb.mi/mi-vla-fortran.exp Andrew Burgess
2015-12-11 21:38 ` [PATCH 1/3] gdb: New set/show max-value-size command Andrew Burgess
2016-01-01 9:43 ` Joel Brobecker
2016-01-05 14:12 ` Andrew Burgess
2016-01-05 15:55 ` Pedro Alves
2016-01-05 16:24 ` Eli Zaretskii
2016-01-06 11:41 ` Andrew Burgess
2016-01-20 10:59 ` PING: " Andrew Burgess
2016-01-20 11:23 ` Eli Zaretskii
2016-01-20 15:23 ` Andrew Burgess
2016-01-28 15:11 ` PING #2: " Andrew Burgess
2016-02-01 3:21 ` Joel Brobecker
2016-02-13 21:40 ` [testsuite patch] testsuite regression: gdb.fortran/vla-value-sub.exp gdb.fortran/vla-value-sub-finish.exp [Re: [PATCH 1/3] gdb: New set/show max-value-size command.] Jan Kratochvil
2016-02-14 0:51 ` Andrew Burgess [this message]
2016-02-14 8:20 ` [commit] " Jan Kratochvil
2016-02-14 4:38 ` Joel Brobecker
2015-12-11 21:38 ` [PATCH 3/3] gdb: Guard against undefined behaviour in mi-vla-fortran.exp Andrew Burgess
2016-01-01 11:08 ` Joel Brobecker
2016-01-05 14:15 ` Andrew Burgess
2015-12-11 21:38 ` [PATCH 2/3] gdb: Set max-value-size before running tests Andrew Burgess
2016-01-01 9:48 ` Joel Brobecker
2016-01-01 9:53 ` Joel Brobecker
2016-01-05 14:14 ` Andrew Burgess
2016-01-01 7:34 ` [PATCH 0/2] Problems with gdb.mi/mi-vla-fortran.exp Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214005108.GE4770@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).