From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87998 invoked by alias); 14 Feb 2016 00:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87563 invoked by uid 89); 14 Feb 2016 00:51:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-languages-length:2855, sk:vlaval, sk:vla-val, UD:vla-value-sub-finish.exp X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 14 Feb 2016 00:51:13 +0000 Received: by mail-wm0-f44.google.com with SMTP id b205so25845185wmb.1 for ; Sat, 13 Feb 2016 16:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=hK1wAZguvfxeR8Mt7TaqZUrZbbwQmsV5aNbvIlMjkag=; b=cgmdtoPFPyG+nID4qmXc6DTnk2utyLdo6OBigaFDmZrtX0/eYCjVYZHK7KtJlCYvJo F7FufEBOWggSX82feTPnBeSpGfpGcBqhOa3xXEWf5pJbE+QAclPyQBoeszk3c91somrB rQqKXiCi6AJ8050N/IgOG12ZNxtkM3UdzM04yjuD28PuMqCupSaAPCpNZ8dUWarYTbjj gLgsv1+OdFIcHzROszVlCWi8JXy3w+gsENZtMKKVctDoPMu9HUtqM0pZLzbw6y9+VwI0 aqXbovnZd8uX510Zg7hnAgO/UUxGAKZLlt31FSNCWXM+lIpVSoHbUY/WpHynxiXwkZWf s9/A== X-Gm-Message-State: AG10YOR+Xbl33WCNnal0fHkJMwT82VEsFkfnJbS2E/fiEAOlMjDH43P9yKU3TPN63ON6Lg== X-Received: by 10.194.3.77 with SMTP id a13mr557103wja.33.1455411070551; Sat, 13 Feb 2016 16:51:10 -0800 (PST) Received: from localhost (host86-138-92-71.range86-138.btcentralplus.com. [86.138.92.71]) by smtp.gmail.com with ESMTPSA id az10sm18547242wjc.28.2016.02.13.16.51.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Feb 2016 16:51:09 -0800 (PST) Date: Sun, 14 Feb 2016 00:51:00 -0000 From: Andrew Burgess To: Jan Kratochvil Cc: Eli Zaretskii , brobecker@adacore.com, gdb-patches@sourceware.org, Pedro Alves Subject: Re: [testsuite patch] testsuite regression: gdb.fortran/vla-value-sub.exp gdb.fortran/vla-value-sub-finish.exp [Re: [PATCH 1/3] gdb: New set/show max-value-size command.] Message-ID: <20160214005108.GE4770@embecosm.com> References: <57e2731e179d11c584e8cde994ab1e822a9893b0.1449869722.git.andrew.burgess@embecosm.com> <20160101094309.GC12416@adacore.com> <20160105141241.GG4242@embecosm.com> <83a8ok570f.fsf@gnu.org> <20160106114049.GJ4242@embecosm.com> <20160213214046.GA17145@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160213214046.GA17145@host1.jankratochvil.net> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00443.txt.bz2 * Jan Kratochvil [2016-02-13 22:40:46 +0100]: > On Wed, 06 Jan 2016 12:40:50 +0100, Andrew Burgess wrote: > > +static int max_value_size = 65536; /* 64k bytes */ > > FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array) > FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was mofified in debugger (passed fixed array) > FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was filled > FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was mofified in debugger > > print array2 > value requires 296352 bytes, which is more than max-value-size > (gdb) FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array) > > OK for check-in? Not a maintainer, but this looks fine to me. Apologies for not spotting the breakage, this error triggered so often in the fortran tests I admit I got a bit lazy and assumed they were all legitimate. Thanks for tracking these down, Andrew > > Tested on x86_64-fedora23-linux-gnu. > > > Jan > gdb/testsuite/ChangeLog > 2016-02-13 Jan Kratochvil > > * gdb.fortran/vla-value-sub-finish.exp (set max-value-size 1024*1024): > New test. > * gdb.fortran/vla-value-sub.exp: Likewise. > > diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp > index c47ef2c..fde6c9f 100644 > --- a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp > +++ b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp > @@ -32,6 +32,8 @@ if ![runto_main] { > > gdb_breakpoint [gdb_get_line_number "array2-almost-filled"] > gdb_continue_to_breakpoint "array2-almost-filled" > +# array2 size is 296352 bytes. > +gdb_test_no_output "set max-value-size 1024*1024" > gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \ > "print array2 in foo after it was filled" > gdb_test "print array2(2,1,1)=20" " = 20" \ > diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub.exp b/gdb/testsuite/gdb.fortran/vla-value-sub.exp > index 361d7a9..179683d 100644 > --- a/gdb/testsuite/gdb.fortran/vla-value-sub.exp > +++ b/gdb/testsuite/gdb.fortran/vla-value-sub.exp > @@ -42,6 +42,8 @@ gdb_test "print array1(1, 1)" " = 30" \ > > gdb_breakpoint [gdb_get_line_number "array2-almost-filled"] > gdb_continue_to_breakpoint "array2-almost-filled (1st)" > +# array2 size is 296352 bytes. > +gdb_test_no_output "set max-value-size 1024*1024" > gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \ > "print array2 in foo after it was filled (passed fixed array)" > gdb_test "print array2(2,1,1)=20" " = 20" \