From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106892 invoked by alias); 18 Feb 2016 09:54:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106871 invoked by uid 89); 18 Feb 2016 09:54:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Feb 2016 09:54:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id DCF938E234; Thu, 18 Feb 2016 09:54:44 +0000 (UTC) Received: from blade.nx (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1I9shKd029700; Thu, 18 Feb 2016 04:54:44 -0500 Received: by blade.nx (Postfix, from userid 1000) id EB06B2643EC; Thu, 18 Feb 2016 09:54:42 +0000 (GMT) Date: Thu, 18 Feb 2016 09:54:00 -0000 From: Gary Benson To: Luis Machado Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [OB PATCH] Add missing cleanup in exec_file_locate_attach Message-ID: <20160218095442.GA1389@blade.nx> References: <20160217135324.GC24631@blade.nx> <1455728537-27577-1-git-send-email-gbenson@redhat.com> <56C4B7AA.60308@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C4B7AA.60308@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00529.txt.bz2 Luis Machado wrote: > On 02/17/2016 03:02 PM, Gary Benson wrote: > > exec_file_locate_attach allocates memory for full_exec_path (using > > either exec_file_find, source_full_path_of or xstrdup) but this > > memory is never freed. This commit adds the necessary cleanup. > > > > Pushed as obvious. > > Well spotted! Thanks :) Cheers, Gary -- http://gbenson.net/