From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105673 invoked by alias); 18 Feb 2016 16:06:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105659 invoked by uid 89); 18 Feb 2016 16:06:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: e06smtp09.uk.ibm.com Received: from e06smtp09.uk.ibm.com (HELO e06smtp09.uk.ibm.com) (195.75.94.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 18 Feb 2016 16:06:44 +0000 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Feb 2016 16:06:40 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 18 Feb 2016 16:06:38 -0000 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id E123B17D8056 for ; Thu, 18 Feb 2016 16:06:56 +0000 (GMT) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1IG6cJv7930344 for ; Thu, 18 Feb 2016 16:06:38 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1IG6bTr019472 for ; Thu, 18 Feb 2016 11:06:38 -0500 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1IG6bRP019468; Thu, 18 Feb 2016 11:06:37 -0500 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 5AA636B9A; Thu, 18 Feb 2016 17:06:37 +0100 (CET) Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch. To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Thu, 18 Feb 2016 16:06:00 -0000 From: "Ulrich Weigand" Cc: lgustavo@codesourcery.com, arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org In-Reply-To: <56C5EAB8.20400@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Feb 18, 2016 05:00:56 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160218160637.5AA636B9A@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021816-0037-0000-0000-000005AAE859 X-SW-Source: 2016-02/txt/msg00547.txt.bz2 Marcin Kościelnicki wrote: > On 18/02/16 16:58, Ulrich Weigand wrote: > > Ah, right. You should probably move the prototype to arch-utils.h > > (and then the implementation to arch-utils.c) to go with the other > > default_ functions. > > Alright, I'll do that. > > > > Since gdbarch.h is included everywhere, we try to avoid having it > > include other headers as far as possible. > > FWIW, the header include I added only ends up in gdbarch.c, .h is > unaffected. Ah, I missed that, sorry. Anyway, it's probably still better to have the routine in arch-utils.[ch] like the others ... Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com