Re: [PATCH 2/5 v4] powerpc: Support z-point type in gdbserver.

["Ulrich Weigand" <uweigand@de.ibm.com>]

> Another old approved patch that I'd like to push.  Testing on 
> ppc+ppc64+ppc64le:
> 
> gdb.base/dprintf.exp: agent: 1st dprintf UNSUPPORTED -> PASS×3
> gdb.base/jit.exp: PIE: one_jit_test-1: set var libname = 
> "SHLIBDIR/jit-solib.so" PASS -> FAIL, on ppc64 only (I don't consider 
> that one a problem, since jit.exp already has lots of similiar FAILs for 
> this arch, nothing really new is broken here)
> gdb.mi/mi-dprintf.exp: mi expect stop FAIL×5 -> PASS×4
> gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1: 
> detach_on_fork=on: displaced=off FAIL -> PASS×3
> gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: 
> cond_bp_target=1: KFAIL (memory error) -> KFAIL (prompt)
> gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: 
> cond_bp_target=[01]: inferior 1 exited PASS×2 -> KFAIL (PRMS: gdb/18749)
> 
> Fixes a lot of gdb.trace tests if I enable tracepoints.
> 
> On 27/06/15 18:21, Wei-cheng Wang wrote:
> > Support z-point, so tracepoints and breakpoints can be inserted at the same
> > location.
> >
> > gdb/gdbserver/ChangeLog
> >
> > 2015-06-27  Wei-cheng Wang  <cole945@gmail.com>
> >
> > 	* linux-ppc-low.c (ppc_supports_z_point_type): New function:
> > 	(ppc_insert_point, ppc_remove_point): Insert/remove z-packet breakpoints.
> > 	(ppc64_emit_ops_vector): Add target ops - ppc_supports_z_point_type,
> > 	ppc_insert_point, ppc_remove_point.

Yes, this is also still OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com