From: Gary Benson <gbenson@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read
Date: Tue, 22 Mar 2016 09:15:00 -0000 [thread overview]
Message-ID: <20160322091527.GA21588@blade.nx> (raw)
In-Reply-To: <20160319201842.GA16540@host1.jankratochvil.net>
Jan Kratochvil wrote:
> gdb/ChangeLog
> 2016-03-19 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * remote.c (remote_pid_to_exec_file): Print warning for unsupported
> PACKET_qXfer_exec_file.
>
> diff --git a/gdb/remote.c b/gdb/remote.c
> index af0a08a..d267736 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -12977,7 +12977,13 @@ remote_pid_to_exec_file (struct target_ops *self, int pid)
> char *annex = NULL;
>
> if (packet_support (PACKET_qXfer_exec_file) != PACKET_ENABLE)
> - return NULL;
> + {
> + warning (_("No executable has been specified (see the \"file\" command) "
> + "and remote gdbserver does not "
> + "support packet \"qXfer:exec-file:read\""
> + " - please use FSF gdbserver version 7.10 or later."));
> + return NULL;
> + }
>
> if (filename != NULL)
> xfree (filename);
This looks good to me.
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2016-03-22 9:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 20:18 Jan Kratochvil
2016-03-22 9:15 ` Gary Benson [this message]
2016-03-22 12:24 ` Pedro Alves
2016-03-22 13:16 ` Jan Kratochvil
2016-03-22 13:56 ` Pedro Alves
2016-03-23 21:15 ` Jan Kratochvil
2016-03-24 16:59 ` Jan Kratochvil
2016-03-24 22:09 ` [patch] Workaround gdbserver<7.7 for setfs [Re: [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read] Jan Kratochvil
2016-03-24 22:32 ` [patchv2 2/2] Workaround gdbserver<7.7 for setfs Jan Kratochvil
2016-03-30 14:17 ` Pedro Alves
2016-04-03 19:30 ` Jan Kratochvil
2016-04-04 21:14 ` [patchv3] " Jan Kratochvil
2016-04-05 16:29 ` Pedro Alves
2016-04-06 13:49 ` [patchv4] " Jan Kratochvil
2016-04-06 14:31 ` Pedro Alves
2016-04-06 15:19 ` [commit] " Jan Kratochvil
2016-04-06 19:09 ` [revert] " Jan Kratochvil
2016-04-26 21:29 ` [patchv5] " Jan Kratochvil
2016-04-27 9:59 ` Pedro Alves
2016-04-27 19:32 ` [commit+7.11] " Jan Kratochvil
2016-04-28 10:36 ` Gary Benson
2016-03-24 22:32 ` [patchv2 1/2] " Jan Kratochvil
2016-04-05 16:32 ` [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read Pedro Alves
2016-04-05 17:14 ` Jan Kratochvil
2016-04-05 16:58 ` Pedro Alves
2016-04-06 14:34 ` [commit] " Jan Kratochvil
2016-04-06 14:49 ` [commit fix] Revert check-in by a mistake in the previous commit [Re: [commit] Suggest newer gdbserver if it has no qXfer:exec-file:read] Jan Kratochvil
2016-04-06 15:04 ` [commit] Suggest newer gdbserver if it has no qXfer:exec-file:read Pedro Alves
2016-04-06 15:29 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322091527.GA21588@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).