From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Gary Benson <gbenson@redhat.com>
Subject: [patchv2 1/2] Workaround gdbserver<7.7 for setfs
Date: Thu, 24 Mar 2016 22:32:00 -0000 [thread overview]
Message-ID: <20160324223220.GA2548@host1.jankratochvil.net> (raw)
In-Reply-To: <20160324220933.GA27445@host1.jankratochvil.net>
[-- Attachment #1: Type: text/plain, Size: 28 bytes --]
There was a bug in patchv1.
[-- Attachment #2: move1.patch --]
[-- Type: text/plain, Size: 3700 bytes --]
gdb/ChangeLog
2016-03-24 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup.
* remote.c (packet_ok): Move it after remote_protocol_packets.
diff --git a/gdb/remote.c b/gdb/remote.c
index af0a08a..bb027cf 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -1301,59 +1301,6 @@ packet_check_result (const char *buf)
return PACKET_UNKNOWN;
}
-static enum packet_result
-packet_ok (const char *buf, struct packet_config *config)
-{
- enum packet_result result;
-
- if (config->detect != AUTO_BOOLEAN_TRUE
- && config->support == PACKET_DISABLE)
- internal_error (__FILE__, __LINE__,
- _("packet_ok: attempt to use a disabled packet"));
-
- result = packet_check_result (buf);
- switch (result)
- {
- case PACKET_OK:
- case PACKET_ERROR:
- /* The stub recognized the packet request. */
- if (config->support == PACKET_SUPPORT_UNKNOWN)
- {
- if (remote_debug)
- fprintf_unfiltered (gdb_stdlog,
- "Packet %s (%s) is supported\n",
- config->name, config->title);
- config->support = PACKET_ENABLE;
- }
- break;
- case PACKET_UNKNOWN:
- /* The stub does not support the packet. */
- if (config->detect == AUTO_BOOLEAN_AUTO
- && config->support == PACKET_ENABLE)
- {
- /* If the stub previously indicated that the packet was
- supported then there is a protocol error. */
- error (_("Protocol error: %s (%s) conflicting enabled responses."),
- config->name, config->title);
- }
- else if (config->detect == AUTO_BOOLEAN_TRUE)
- {
- /* The user set it wrong. */
- error (_("Enabled packet %s (%s) not recognized by stub"),
- config->name, config->title);
- }
-
- if (remote_debug)
- fprintf_unfiltered (gdb_stdlog,
- "Packet %s (%s) is NOT supported\n",
- config->name, config->title);
- config->support = PACKET_DISABLE;
- break;
- }
-
- return result;
-}
-
enum {
PACKET_vCont = 0,
PACKET_X,
@@ -1496,6 +1443,59 @@ enum {
static struct packet_config remote_protocol_packets[PACKET_MAX];
+static enum packet_result
+packet_ok (const char *buf, struct packet_config *config)
+{
+ enum packet_result result;
+
+ if (config->detect != AUTO_BOOLEAN_TRUE
+ && config->support == PACKET_DISABLE)
+ internal_error (__FILE__, __LINE__,
+ _("packet_ok: attempt to use a disabled packet"));
+
+ result = packet_check_result (buf);
+ switch (result)
+ {
+ case PACKET_OK:
+ case PACKET_ERROR:
+ /* The stub recognized the packet request. */
+ if (config->support == PACKET_SUPPORT_UNKNOWN)
+ {
+ if (remote_debug)
+ fprintf_unfiltered (gdb_stdlog,
+ "Packet %s (%s) is supported\n",
+ config->name, config->title);
+ config->support = PACKET_ENABLE;
+ }
+ break;
+ case PACKET_UNKNOWN:
+ /* The stub does not support the packet. */
+ if (config->detect == AUTO_BOOLEAN_AUTO
+ && config->support == PACKET_ENABLE)
+ {
+ /* If the stub previously indicated that the packet was
+ supported then there is a protocol error. */
+ error (_("Protocol error: %s (%s) conflicting enabled responses."),
+ config->name, config->title);
+ }
+ else if (config->detect == AUTO_BOOLEAN_TRUE)
+ {
+ /* The user set it wrong. */
+ error (_("Enabled packet %s (%s) not recognized by stub"),
+ config->name, config->title);
+ }
+
+ if (remote_debug)
+ fprintf_unfiltered (gdb_stdlog,
+ "Packet %s (%s) is NOT supported\n",
+ config->name, config->title);
+ config->support = PACKET_DISABLE;
+ break;
+ }
+
+ return result;
+}
+
/* Returns the packet's corresponding "set remote foo-packet" command
state. See struct packet_config for more details. */
next prev parent reply other threads:[~2016-03-24 22:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 20:18 [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read Jan Kratochvil
2016-03-22 9:15 ` Gary Benson
2016-03-22 12:24 ` Pedro Alves
2016-03-22 13:16 ` Jan Kratochvil
2016-03-22 13:56 ` Pedro Alves
2016-03-23 21:15 ` Jan Kratochvil
2016-03-24 16:59 ` Jan Kratochvil
2016-03-24 22:09 ` [patch] Workaround gdbserver<7.7 for setfs [Re: [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read] Jan Kratochvil
2016-03-24 22:32 ` Jan Kratochvil [this message]
2016-03-24 22:32 ` [patchv2 2/2] Workaround gdbserver<7.7 for setfs Jan Kratochvil
2016-03-30 14:17 ` Pedro Alves
2016-04-03 19:30 ` Jan Kratochvil
2016-04-04 21:14 ` [patchv3] " Jan Kratochvil
2016-04-05 16:29 ` Pedro Alves
2016-04-06 13:49 ` [patchv4] " Jan Kratochvil
2016-04-06 14:31 ` Pedro Alves
2016-04-06 15:19 ` [commit] " Jan Kratochvil
2016-04-06 19:09 ` [revert] " Jan Kratochvil
2016-04-26 21:29 ` [patchv5] " Jan Kratochvil
2016-04-27 9:59 ` Pedro Alves
2016-04-27 19:32 ` [commit+7.11] " Jan Kratochvil
2016-04-28 10:36 ` Gary Benson
2016-04-05 16:32 ` [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read Pedro Alves
2016-04-05 17:14 ` Jan Kratochvil
2016-04-05 16:58 ` Pedro Alves
2016-04-06 14:34 ` [commit] " Jan Kratochvil
2016-04-06 14:49 ` [commit fix] Revert check-in by a mistake in the previous commit [Re: [commit] Suggest newer gdbserver if it has no qXfer:exec-file:read] Jan Kratochvil
2016-04-06 15:04 ` [commit] Suggest newer gdbserver if it has no qXfer:exec-file:read Pedro Alves
2016-04-06 15:29 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324223220.GA2548@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).