From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62661 invoked by alias); 1 Apr 2016 14:43:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62643 invoked by uid 89); 1 Apr 2016 14:43:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=elf.h, elfh, UD:elf.h, daily X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 01 Apr 2016 14:43:54 +0000 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Apr 2016 15:43:51 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 1 Apr 2016 15:43:49 +0100 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id A10051B0805F for ; Fri, 1 Apr 2016 15:44:23 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u31EhlPb5112106 for ; Fri, 1 Apr 2016 14:43:47 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u31Ehlf0025071 for ; Fri, 1 Apr 2016 08:43:47 -0600 Received: from oc7340732750.ibm.com (icon-9-164-131-74.megacenter.de.ibm.com [9.164.131.74]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u31Ehll9025033; Fri, 1 Apr 2016 08:43:47 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 44B5DCA06; Fri, 1 Apr 2016 16:43:46 +0200 (CEST) Subject: Re: [PATCH 2/4 v3] IPA: Add alloc_jump_pad_buffer target hook. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Fri, 01 Apr 2016 14:43:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1459387001-18803-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Mar 31, 2016 03:16:41 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20160401144346.44B5DCA06@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040114-0013-0000-0000-00000C982A14 X-SW-Source: 2016-04/txt/msg00007.txt.bz2 > * linux-aarch64-ipa.c: Add and includes. > (alloc_jump_pad_buffer): New function. > * linux-amd64-ipa.c: Add include. > (alloc_jump_pad_buffer): New function. > * linux-i386-ipa.c (alloc_jump_pad_buffer): New function. > * linux-s390-ipa.c: Add and includes. > (alloc_jump_pad_buffer): New function. > * tracepoint.c (getauxval) [!HAVE_GETAUXVAL]: New function. > (initialize_tracepoint): Delegate to alloc_jump_pad_buffer. > * tracepoint.h (alloc_jump_pad_buffer): New prototype. > (getauxval) [!HAVE_GETAUXVAL]: New prototype. This caused a build failure on my RHEL5 Cell daily build, due to gdb/gdbserver/linux-ppc-ipa.c: In function 'alloc_jump_pad_buffer': gdb/gdbserver/linux-ppc-ipa.c:120: error: 'AT_PHDR' undeclared (first use in this function) The problem seems to be that this system is so old it doesn't have a header. You do provide a fallback getauxval implementation for those systems, but the AT_PHDR value isn't available. It is actually defined in my system headers, in , but this isn't pulled in --- usually it would be implicitly included from . It might be best to add an explicit #include to all files that make use of AT_... constants, in case HAVE_GETAUXVAL is false. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com