From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77631 invoked by alias); 2 Jun 2016 18:22:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77620 invoked by uid 89); 2 Jun 2016 18:22:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,TVD_APPROVED autolearn=no version=3.3.2 spammy=adjusting, hey X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 02 Jun 2016 18:22:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 170AC116E2D; Thu, 2 Jun 2016 14:22:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ojUaqBzTQzSN; Thu, 2 Jun 2016 14:22:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D9DD8116E36; Thu, 2 Jun 2016 14:22:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0D3F5428FB; Thu, 2 Jun 2016 11:22:15 -0700 (PDT) Date: Thu, 02 Jun 2016 18:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix PR python/18984 Message-ID: <20160602182215.GB3769@adacore.com> References: <1463614581-18216-1-git-send-email-tom@tromey.com> <87shwvwjoq.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87shwvwjoq.fsf@tromey.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-06/txt/msg00043.txt.bz2 Hey Tom, > Tom> This fixes PR python/18984. > Tom> The bug is that gdbpy_solib_name uses GDB_PY_LL_ARG, whereas it should > Tom> use GDB_PY_LLU_ARG to avoid overflow. > > Tom> Built and tested on x86-64 Fedora 23. > > Tom> 2016-05-18 Tom Tromey > > Tom> PR python/18984: > Tom> * python/python.c (gdbpy_solib_name): Use GDB_PY_LLU_ARG. > > Ping. > > This one bit me again today, and the fix is particularly simple. Sorry about the delay. The code patch looks good to me. For the testcase patch, you said you'd be adjusting it for Python 3 as well? Just for the avoidance of doubt, you're pre-approved on that as well. If there are comments on it, we can address those later, as it wouldn't break GDB anyways. Thanks! -- Joel