From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [testsuite patch] Fix gdb.gdb/selftest.exp for C++-O2-g-built GDB
Date: Mon, 18 Jul 2016 11:40:00 -0000 [thread overview]
Message-ID: <20160718114002.GA26094@host1.jankratochvil.net> (raw)
In-Reply-To: <CAH=s-POVxrjfG1YFTjdmAj65zTpeY4j2XsJEjBDUBSsBc_7Mhg@mail.gmail.com>
On Mon, 18 Jul 2016 11:45:36 +0200, Yao Qi wrote:
> OK, I think we still need to convert gdb.gdb/selftest.exp using proc
> do_self_tests to simplify the code, and then, improve procs in
> lib/selftest-support.exp to handle the fails when GDB is compiled with
> optimization. What do you think? If you agree on this, I can commit
> my patch above, and tweak lib/selftest-support.exp to fix your fails.
I have no opinion on it. I have no idea what's the purpose of
gdb.gdb/selftest.exp . I see during the past 10 years I saw an upstream catch
of one regression(s) by but it was more an accident and it could happen with
some other regular testsuite-built inferior if it was testing the same
feature.
I just want to keep it regression-free so do whatever you find fine, I can
rebase my patch on top of it, but I would like no regression for -O2 -g GDB
and I would like not to carry this patch off-trunk forever.
Jan
next prev parent reply other threads:[~2016-07-18 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 13:14 Jan Kratochvil
2016-07-18 8:06 ` Yao Qi
2016-07-18 8:18 ` Jan Kratochvil
2016-07-18 9:45 ` Yao Qi
2016-07-18 11:40 ` Jan Kratochvil [this message]
2016-07-19 9:47 ` Yao Qi
2016-07-20 14:29 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718114002.GA26094@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).