From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110475 invoked by alias); 15 Aug 2016 10:22:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110462 invoked by uid 89); 15 Aug 2016 10:22:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=approve, matthew, Matthew X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Aug 2016 10:22:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 179714E333; Mon, 15 Aug 2016 10:22:23 +0000 (UTC) Received: from blade.nx (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7FAMMOo027674; Mon, 15 Aug 2016 06:22:22 -0400 Received: by blade.nx (Postfix, from userid 1000) id A7057263C89; Mon, 15 Aug 2016 11:22:21 +0100 (BST) Date: Mon, 15 Aug 2016 10:22:00 -0000 From: Gary Benson To: Matthew Wahab Cc: gdb-patches@sourceware.org Subject: Re: [GDB][PR gdb/20457] Fix builds broken by proc-service changes. Message-ID: <20160815102221.GA9442@blade.nx> References: <57ADDA16.9060201@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57ADDA16.9060201@foss.arm.com> X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00157.txt.bz2 Hi Matthew, Matthew Wahab wrote: > This patch moves the include for gregset.h to before the code > guarded by HAVE_PROC_SERIVCE_H, so that it is always included. > This is enough to fix the build. This patch looks good to me, though I'm not a maintainer so can't approve a push. Cheers, Gary -- http://gbenson.net/