* dejagnu: Disable ccache
@ 2016-09-04 8:44 Jan Kratochvil
2016-09-04 10:07 ` Ben Elliston
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kratochvil @ 2016-09-04 8:44 UTC (permalink / raw)
To: dejagnu; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]
Hi,
there were always various problems with compatibility with ccache:
https://bugzilla.redhat.com/show_bug.cgi?id=488863
https://bugzilla.redhat.com/show_bug.cgi?id=759592
https://sourceware.org/ml/gdb-patches/2009-02/msg00397.html
IMO in a summary ccache finds more a benefit of faster compilation despite the
debug info is no longer exactly the same (as without ccache).
Although for example in this case ccache helped to find a real GDB bug:
https://sourceware.org/ml/gdb-patches/2015-01/msg00497.html
For the GDB testcases ccache has (IMO) no real performance advantage and it
just brings heisenbugs - false FAILs - from time to time:
Breakpoint 1, main () at gdb/testsuite/gdb.base/vdso-warning.c:21^M
21 return 0;^M
(gdb) PASS: gdb.base/vdso-warning.exp: run: startup
->
Breakpoint 1, main () at gdb/testsuite/gdb.base/hbreak-unmapped.c:21^M
21 return 0;^M
(gdb) FAIL: gdb.base/vdso-warning.exp: run: startup
So I find most safe and easy to just disable ccache for all testsuites.
I guess this issues can be considered more general than just for the GDB
testsuite, therefore posting it for dejagnu.
Jan
[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 883 bytes --]
diff --git a/ChangeLog b/ChangeLog
index 4880003..916fa04 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2016-09-04 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * runtest.exp: Set CCACHE_DISABLE, clear CCACHE_NODISABLE.
+
2016-06-28 Ben Elliston <bje@gnu.org>
* aclocal.m4, Makefile.in: Regenerate with automake 1.15.
diff --git a/runtest.exp b/runtest.exp
index 2c6ca5d..0415e4e 100644
--- a/runtest.exp
+++ b/runtest.exp
@@ -87,6 +87,11 @@ set target_cpu "" ;# type of the cpu tests are running on
set target_alias "" ;# standard abbreviation of target
set compiler_flags "" ;# the flags used by the compiler
+# Various ccache versions provide incorrect debug info such as ignoring
+# different current directory, breaking GDB testsuite.
+set env(CCACHE_DISABLE) 1
+unset -nocomplain env(CCACHE_NODISABLE)
+
#
# some convenience abbreviations
#
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dejagnu: Disable ccache
2016-09-04 8:44 dejagnu: Disable ccache Jan Kratochvil
@ 2016-09-04 10:07 ` Ben Elliston
2016-09-04 15:08 ` [gdb testsuite patch] " Jan Kratochvil
0 siblings, 1 reply; 5+ messages in thread
From: Ben Elliston @ 2016-09-04 10:07 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: dejagnu, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
On Sun, Sep 04, 2016 at 10:44:27AM +0200, Jan Kratochvil wrote:
> So I find most safe and easy to just disable ccache for all
testsuites.
Thanks--I agree. As a principle, it makes no sense to cache in a test
environment.
Cheers, Ben
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [gdb testsuite patch] Disable ccache
2016-09-04 10:07 ` Ben Elliston
@ 2016-09-04 15:08 ` Jan Kratochvil
2016-09-15 11:59 ` Pedro Alves
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kratochvil @ 2016-09-04 15:08 UTC (permalink / raw)
To: gdb-patches; +Cc: Ben Elliston
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
On Sun, 04 Sep 2016 12:07:04 +0200, Ben Elliston wrote:
> On Sun, Sep 04, 2016 at 10:44:27AM +0200, Jan Kratochvil wrote:
> > So I find most safe and easy to just disable ccache for all
> > testsuites.
>
> Thanks--I agree. As a principle, it makes no sense to cache in a test
> environment.
So now it just could be also included in GDB lib/future.exp.
OK to check it in?
Jan
[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 599 bytes --]
gdb/testsuite/ChangeLog
2016-09-04 Jan Kratochvil <jan.kratochvil@redhat.com>
* lib/future.exp: Set CCACHE_DISABLE, clear CCACHE_NODISABLE.
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
index 2ecff2e..e7c9d9a 100644
--- a/gdb/testsuite/lib/future.exp
+++ b/gdb/testsuite/lib/future.exp
@@ -666,3 +666,8 @@ if {[info procs lreverse] == ""} {
return $retval
}
}
+
+# Various ccache versions provide incorrect debug info such as ignoring
+# different current directory, breaking GDB testsuite.
+set env(CCACHE_DISABLE) 1
+unset -nocomplain env(CCACHE_NODISABLE)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gdb testsuite patch] Disable ccache
2016-09-04 15:08 ` [gdb testsuite patch] " Jan Kratochvil
@ 2016-09-15 11:59 ` Pedro Alves
2016-09-15 12:07 ` [commit] " Jan Kratochvil
0 siblings, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2016-09-15 11:59 UTC (permalink / raw)
To: Jan Kratochvil, gdb-patches; +Cc: Ben Elliston
On 09/04/2016 04:08 PM, Jan Kratochvil wrote:
> On Sun, 04 Sep 2016 12:07:04 +0200, Ben Elliston wrote:
>> On Sun, Sep 04, 2016 at 10:44:27AM +0200, Jan Kratochvil wrote:
>>> So I find most safe and easy to just disable ccache for all
>>> testsuites.
>>
>> Thanks--I agree. As a principle, it makes no sense to cache in a test
>> environment.
>
> So now it just could be also included in GDB lib/future.exp.
>
> OK to check it in?
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread
* [commit] [gdb testsuite patch] Disable ccache
2016-09-15 11:59 ` Pedro Alves
@ 2016-09-15 12:07 ` Jan Kratochvil
0 siblings, 0 replies; 5+ messages in thread
From: Jan Kratochvil @ 2016-09-15 12:07 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Ben Elliston
On Thu, 15 Sep 2016 13:59:31 +0200, Pedro Alves wrote:
> On 09/04/2016 04:08 PM, Jan Kratochvil wrote:
> > OK to check it in?
>
> OK.
49b4de64242d4ae035e0e2197837278e33c187fc
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-15 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-04 8:44 dejagnu: Disable ccache Jan Kratochvil
2016-09-04 10:07 ` Ben Elliston
2016-09-04 15:08 ` [gdb testsuite patch] " Jan Kratochvil
2016-09-15 11:59 ` Pedro Alves
2016-09-15 12:07 ` [commit] " Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).