From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: cel@us.ibm.com (Carl E. Love)
Cc: arnez@linux.vnet.ibm.com (Andreas Arnez),
gdb-patches@sourceware.org, cel@us.ibm.com,
emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado),
Ulrich.Weigand@de.ibm.com (Ulrich Weigand)
Subject: Re: [PATCH] Fix for gdb.server/non-existing-program.exp test case
Date: Tue, 13 Sep 2016 13:26:00 -0000 [thread overview]
Message-ID: <20160913132630.92A081161D1@oc8523832656.ibm.com> (raw)
In-Reply-To: <1473260901.4102.84.camel@us.ibm.com> from "Carl E. Love" at Sep 07, 2016 08:08:21 AM
Carl Love wrote:
> 2016-09-06 Carl Love <cel@us.ibm.com>
>
> * server.c (start_inferior): Do not call
> function target_post_create_inferior () if the
> inferior process has already exited.
The patch makes sense to me, however there seem to be
some formatting issues (mail client problems?):
> + /* The last_status.kind was set by the call to
> ptrace(PTRACE_TRACEME, ...).
> + The function linux_wait() has also been called. At this point,
> the
> + target process, if it exits, is stopped. Depending on the
> architecture,
> + the function target_post_create_inferior () may make additional
> ptrace ()
> + calls that will fail if the target has already exited.
> + */
Please make sure this is properly formatted (and does not exceed
the 80 characters per line limit).
Also, the comment seems a bit too specific; this file is also used
for targets other than Linux that may not use ptrace specifically.
I'd word the comment a bit more generically, along the lines of
"Do not call target_post_create_inferior if the process has already
exited, since the target implementation of that routine may rely on
the process being live."
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-09-13 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:08 Carl E. Love
2016-09-13 13:26 ` Ulrich Weigand [this message]
2016-09-13 15:25 ` Carl E. Love
2016-09-13 15:37 ` Ulrich Weigand
2016-09-13 17:10 ` Carl E. Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913132630.92A081161D1@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=cel@us.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).