From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129047 invoked by alias); 19 Sep 2016 16:18:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129029 invoked by uid 89); 19 Sep 2016 16:18:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1125, alternatively X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Sep 2016 16:18:39 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8JGIbpM075582 for ; Mon, 19 Sep 2016 12:18:38 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 25h2cfv20b-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 19 Sep 2016 12:18:37 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Sep 2016 17:18:28 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Sep 2016 17:18:25 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 353EB1B08067 for ; Mon, 19 Sep 2016 17:20:16 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8JGIPsA5439862 for ; Mon, 19 Sep 2016 16:18:25 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8JGIOWZ010640 for ; Mon, 19 Sep 2016 12:18:24 -0400 Received: from oc8523832656.ibm.com (dyn-9-152-213-149.boeblingen.de.ibm.com [9.152.213.149]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8JGIOij010631; Mon, 19 Sep 2016 12:18:24 -0400 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 53B15FFEFB; Mon, 19 Sep 2016 18:18:24 +0200 (CEST) Subject: Re: [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls To: palves@redhat.com (Pedro Alves) Date: Mon, 19 Sep 2016 16:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Pedro Alves" at Sep 19, 2016 04:59:15 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091916-0008-0000-0000-000002CE01C7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091916-0009-0000-0000-00001A0414CF Message-Id: <20160919161824.53B15FFEFB@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-19_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 spamscore=1 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609190220 X-SW-Source: 2016-09/txt/msg00212.txt.bz2 > On 09/19/2016 04:23 PM, Pedro Alves wrote: > > On 09/19/2016 03:56 PM, Ulrich Weigand wrote: > >> Pedro Alves wrote: > >> > >>> I tried a --disable-nls with both gcc 5.1 and 4.7 here, and it > >>> doesn't trigger this. I can't seem to find the libintl.h inclusion > >>> you're seeing. Sounds like that was changed at some point. > >> > >> Yes, it looks like these days the C++ headers include a lot fewer > >> of the base C headers (fixing namespace pollution, maybe?). > > > > Yeah, I assume so. > > > >>> Alternatively, simply remove the troublesome *gettext and *textdomain > >>> macros, leaving only the _ and N_ ones. I can't seem to find any > >>> directly reference to gettext in the tree. The textdomain calls > >>> in main.c would need to be wrapped in #ifdef ENABLE_NLS, but > >>> likes like that is all. > >> > >> This would also work, and seems the cleanest solution. > > > > OK, I'm testing a patch. > > I've pushed this in now. Thanks, Pedro! Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com