From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [testsuite patch] Fix recent GCC FAIL: gdb.arch/i386-signal.exp
Date: Mon, 03 Oct 2016 20:35:00 -0000 [thread overview]
Message-ID: <20161003203500.GA2251@host1.jankratochvil.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi,
gcc-6.2.1-2.fc24.x86_64
(gdb) backtrace 10^M
#0 func () at .../gdb/testsuite/gdb.arch/i386-signal.c:26^M
#1 <signal handler called>^M
#2 0x0000000000400588 in main () at .../gdb/testsuite/gdb.arch/i386-signal.c:31^M
(gdb) FAIL: gdb.arch/i386-signal.exp: backtrace 10
(gdb) disas/s
Dump of assembler code for function main:
.../gdb/testsuite/gdb.arch/i386-signal.c:
30 {
0x000000000040057f <+0>: push %rbp
0x0000000000400580 <+1>: mov %rsp,%rbp
31 setup ();
0x0000000000400583 <+4>: callq 0x400590 <setup>
=> 0x0000000000400588 <+9>: mov $0x0,%eax
32 }
0x000000000040058d <+14>: pop %rbp
0x000000000040058e <+15>: retq
End of assembler dump.
The two attached patch chunks each fixes the FAIL on its own.
The .exp patch is an obvious typo fix I think. The regex was written to
accept "ADDR in main" and I find it OK as checking .debug_line validity is not
the purpose of this testfile.
The .c patch will properly create a new corresponding source line .debug_line
entry for the 'mov $0x0,%eax' instruction and I also do not think it is
relevant to the purpose of this testfile.
gcc-4.8.5-11.el7.x86_64 did not put the 'mov $0x0,%eax' instruction there at
all so there was no problem with .debug_line.
Tested on {x86_64,x86_64-m32}-fedora24-linux-gnu.
OK to check it in?
Thanks,
Jan
[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 1067 bytes --]
gdb/testsuite/ChangeLog
2016-10-03 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.arch/i386-signal.c (main): Add return 0.
* gdb.arch/i386-signal.exp (backtrace 10): Fix #2 typo.
diff --git a/gdb/testsuite/gdb.arch/i386-signal.c b/gdb/testsuite/gdb.arch/i386-signal.c
index c5a311e..c168d56 100644
--- a/gdb/testsuite/gdb.arch/i386-signal.c
+++ b/gdb/testsuite/gdb.arch/i386-signal.c
@@ -29,6 +29,7 @@ int
main (void)
{
setup ();
+ return 0;
}
/* Create an imitation signal frame. This will work on any x86 or
diff --git a/gdb/testsuite/gdb.arch/i386-signal.exp b/gdb/testsuite/gdb.arch/i386-signal.exp
index 276b7c0..51a3a25 100644
--- a/gdb/testsuite/gdb.arch/i386-signal.exp
+++ b/gdb/testsuite/gdb.arch/i386-signal.exp
@@ -35,6 +35,6 @@ gdb_load ${binfile}
runto func
gdb_test "backtrace 10" \
- "#0 ($hex in )?func.*\r\n#1 <signal handler called>\r\n#2 ($hex in)?main.*"
+ "#0 ($hex in )?func.*\r\n#1 <signal handler called>\r\n#2 ($hex in )?main.*"
gdb_test "finish" "Run till exit from \#0 func.*<signal handler called>"
next reply other threads:[~2016-10-03 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 20:35 Jan Kratochvil [this message]
2016-10-04 16:08 ` Yao Qi
2016-10-04 16:19 ` Jan Kratochvil
2016-10-04 16:39 ` Jan Kratochvil
2016-10-05 8:15 ` Yao Qi
2016-10-05 19:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003203500.GA2251@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).