From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya)
Cc: gdb-patches@sourceware.org
Subject: Re: set sysroot command on AIX has no effect.
Date: Mon, 10 Oct 2016 16:29:00 -0000 [thread overview]
Message-ID: <20161010162853.BEB9D10C212@oc8523832656.ibm.com> (raw)
In-Reply-To: <OF715ED758.00DC97FD-ON65258048.00413E8B-65258048.0042F442@notes.na.collabserv.com> from "Sangamesh Mallayya" at Oct 10, 2016 05:41:21 PM
Sangamesh Mallayya wrote:
> Here is the change i have it right now which takes care of.
>
> 1) calling solib_find and then solib_bfd_fopen.
> 2) Appending parenthesized member name.
This is looking mostly good. The one thing I don't like is all the extra
xfree calls. I think a better way would to not actually xstrdup the found
pathname early after all, but instead just get it from the BFD. So instead
of the original:
xfree (bfd_get_filename (object_bfd));
object_bfd->filename = xstrdup (pathname);
you'd do something like:
object_bfd->filename = xrealloc (object_bfd->filename, ...);
strcat (object_bfd->filename, sep);
> + /* Calling solib_find makes certain that sysroot path is set properly
> + if program has a dependency on .a archive and sysroot is set via
> + set sysroot command */
Minor coding style issue: sentences in a comment should end with a '.'
followed by two spaces, like so:
... set sysroot command. */
> + found_pathname1 = xstrdup (found_pathname);
> + found_path_len = strlen (found_pathname1) + strlen (sep);
> + found_pathname1 = xrealloc (found_pathname1, found_path_len);
See comment above, but also: there should be a "+ 1" for the null
terminator in the length computation somewhere.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-10-10 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 9:05 Sangamesh Mallayya
2016-09-29 15:33 ` Ulrich Weigand
2016-09-30 14:15 ` Sangamesh Mallayya
2016-09-30 14:38 ` Ulrich Weigand
2016-10-04 13:19 ` Sangamesh Mallayya
2016-10-07 19:31 ` Ulrich Weigand
2016-10-08 13:15 ` Sangamesh Mallayya
2016-10-08 14:38 ` Ulrich Weigand
2016-10-10 12:11 ` Sangamesh Mallayya
2016-10-10 16:29 ` Ulrich Weigand [this message]
2016-10-11 7:17 ` Ulrich Weigand
2016-10-13 13:42 ` Sangamesh Mallayya
2016-10-13 14:03 ` Ulrich Weigand
2016-10-13 17:44 ` Sangamesh Mallayya
2016-10-14 13:13 ` Ulrich Weigand
[not found] <OFBAE0EEF6.511F8BA2-ON6525802D.00305F69-6525802D.0031DA2D@LocalDomain>
2016-09-27 11:39 ` Sangamesh Mallayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010162853.BEB9D10C212@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).