From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: MinGW compilation errors due to strcasecmp
Date: Fri, 28 Oct 2016 18:40:00 -0000 [thread overview]
Message-ID: <20161028184029.GA3922@adacore.com> (raw)
In-Reply-To: <834m4f8kr7.fsf@gnu.org>
Hi Eli,
> > > windows-nat.c: In function 'so_list* windows_make_so(const char*, LPVOID)':
> > > windows-nat.c:608:35: error: 'strcasecmp' was not declared in this scope
> > > if (strcasecmp (buf, "ntdll.dll") == 0)
> > > ^
> > > windows-nat.c: In function 'int envvar_cmp(const void*, const void*)':
> > > windows-nat.c:2031:28: error: 'strcasecmp' was not declared in this scope
> > > return strcasecmp (*p, *q);
> > > ^
> > > Makefile:1134: recipe for target `windows-nat.o' failed
> > > make[2]: *** [windows-nat.o] Error 1
> > >
> > > A similar error happens in stap-probe.c.
> > >
> > > The reason for this is that MinGW runtime changed the place where the
> > > prototypes of strcasecmp and strncasecmp are declared: they are now in
> > > strings.h (which AFAIU is more compatible to other systems). But we
> > > don't include strings.h anywhere, although the configure script probes
> > > for it. I guess other platforms include that header indirectly
> > > somehow.
> > >
> > > My suggestion is to include it in common-defs.h, as shown below.
> > >
> > > Is it okay to push such a change to the repository (with a suitable
> > > ChangeLog entry, of course)?
> >
> > Sure.
>
> Pushed to master and cherry-picked to the 7.12 branch.
Was there a PR number of this issue? Once the first release is
out for a given branch, the protocol is to make sure that every
change that goes in is attached to a PR number, and that either:
- This PR number is listed as done in the Wiki page for that release; or
- The PR's milestone is set to the (minor) release the fix is in.
That way, it's easy for me to announce the fixes in a corrective
release. Otherwise, I have to go dig each commit (lost in the sea
of daily version number updates), and figure out what they fix.
Thanks,
--
Joel
next prev parent reply other threads:[~2016-10-28 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 11:20 Eli Zaretskii
2016-10-12 17:46 ` Pedro Alves
2016-10-14 7:15 ` Eli Zaretskii
2016-10-28 18:40 ` Joel Brobecker [this message]
2016-10-29 8:07 ` Eli Zaretskii
2016-10-31 12:34 ` Joel Brobecker
2016-10-31 16:40 ` Eli Zaretskii
2016-11-19 18:25 ` Joel Brobecker
2016-11-19 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028184029.GA3922@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).