From: Yao Qi <qiyaoltc@gmail.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: user-agent@de.ibm.com,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: set_value_component_location in apply_val_pretty_printer
Date: Mon, 21 Nov 2016 20:37:00 -0000 [thread overview]
Message-ID: <20161121203724.ttcwotysdozdzn7v@localhost> (raw)
In-Reply-To: <CAH=s-PMRLNNPzwMDMiZV1L6cqvx58u_Fk_ng9JLLbyQLQC2uOA@mail.gmail.com>
On Mon, Nov 21, 2016 at 06:23:47PM +0000, Yao Qi wrote:
> I removed the code setting VALUE_NEXT_FRAME_ID, but
> value_from_component only sets VALUE_FRAME_ID. The change
> above is not equivalent, and it causes some regressions in
> https://sourceware.org/ml/gdb-testers/2016-q4/msg03381.html
>
> Sorry about that. The fix would be setting both
> VALUE_NEXT_FRAME_ID and VALUE_FRAME_ID in
> value_from_component. I'll give a fix.
>
Oh, looks we renamed VALUE_FRAME_ID to VALUE_NEXT_FRAME_ID recently,
https://sourceware.org/ml/gdb-patches/2016-11/msg00018.html
and I regression tested against a copy of one-week-old gdb, but
didn't see the regression. The fix would be replacing VALUE_FRAME_ID
with VALUE_NEXT_FRAME_ID in my patch. Testing the fix...
--
Yao
next prev parent reply other threads:[~2016-11-21 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 14:18 Yao Qi
2016-10-28 18:58 ` Ulrich Weigand
2016-10-31 3:07 ` Tom Tromey
2016-11-14 12:52 ` Yao Qi
2016-11-14 16:38 ` Ulrich Weigand
2016-11-21 14:14 ` Yao Qi
2016-11-21 18:23 ` Yao Qi
2016-11-21 20:37 ` Yao Qi [this message]
2016-11-22 9:00 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121203724.ttcwotysdozdzn7v@localhost \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=user-agent@de.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).