From: Yao Qi <qiyaoltc@gmail.com>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple
Date: Tue, 29 Nov 2016 14:49:00 -0000 [thread overview]
Message-ID: <20161129144851.GF22209@E107787-LIN> (raw)
In-Reply-To: <e691f869-9cb9-33ac-65ac-59c653771d91@codesourcery.com>
On Mon, Nov 28, 2016 at 10:06:28AM -0600, Luis Machado wrote:
> On 11/27/2016 11:09 AM, Yao Qi wrote:
> >On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote:
> >>This fixes offender testcases that have test names starting with uppercase
> >>when using gdb_test_multiple in a single-line construct.
> >>
> >>gdb/testsuite/ChangeLog
> >>2016-11-25 Luis Machado <lgustavo@codesourcery.com>
> >>
> >> Fix test names starting with uppercase throughout the files.
> >>
> >> * gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> >> * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> >> * gdb/testsuite/gdb.base/disasm-end-cu.exp
> >> * gdb/testsuite/gdb.base/macscp.exp
> >> * gdb/testsuite/gdb.base/pending.exp
> >> * gdb/testsuite/gdb.base/watch_thread_num.exp
> >> * gdb/testsuite/gdb.cp/exception.exp
> >> * gdb/testsuite/gdb.cp/gdb2495.exp
> >> * gdb/testsuite/gdb.cp/local.exp
> >> * gdb/testsuite/gdb.python/py-evsignal.exp
> >> * gdb/testsuite/gdb.python/python.exp
> >> * gdb/testsuite/gdb.trace/tracecmd.exp
> >
> >Drop "gdb/testsuite/". Patch is good to me, but I think we need to
> >enforce a rule in "proc gdb_test_multiple" that test message should
> >start with a lower case letter, emit an ERROR if it starts with
> >uppercase.
> >
>
> Do you mean just for gdb_test_multiple?
Yes,
>
> It can be tricky, since one is still free to start the sentences
> with something like "ARM ..." or some other technology name. So
> unfortunately we can't be too strict. I wish we could.
Do we have some many technology names? We have a white list of these
technology names which can be capitalized in test message.
--
Yao (é½å°§)
next prev parent reply other threads:[~2016-11-29 14:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 20:54 [PATCH v2 0/8] Fix gdb's testsuite test names Luis Machado
2016-11-25 20:54 ` [PATCH v2 6/8] Fix test names starting with uppercase using multi-line gdb_test_no_output Luis Machado
2016-11-30 20:12 ` Pedro Alves
2016-11-25 20:54 ` [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-30 20:47 ` Pedro Alves
2016-11-30 21:05 ` Luis Machado
2016-11-30 22:14 ` Pedro Alves
2016-11-25 20:54 ` [PATCH v2 3/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-27 16:58 ` Yao Qi
2016-11-25 20:55 ` [PATCH v2 1/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-29 21:37 ` Yao Qi
2016-11-25 20:55 ` [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-27 17:10 ` Yao Qi
2016-11-28 16:06 ` Luis Machado
2016-11-29 14:49 ` Yao Qi [this message]
2016-11-29 15:07 ` Luis Machado
2016-11-29 20:55 ` Yao Qi
2016-11-29 21:14 ` Luis Machado
2016-11-30 19:56 ` Pedro Alves
2016-11-25 20:55 ` [PATCH v2 2/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-27 16:48 ` Yao Qi
2016-11-28 18:13 ` [PATCH v3 " Luis Machado
2016-11-25 20:55 ` [PATCH v2 5/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-30 20:11 ` Pedro Alves
2016-11-30 20:25 ` Luis Machado
2016-11-25 20:55 ` [PATCH v2 8/8] Fixup testcases outputting own name as a test name and standardize failed compilation messages Luis Machado
2016-12-01 11:08 ` Pedro Alves
2016-12-01 13:15 ` Luis Machado
2016-12-01 17:20 ` [PATCH v3 " Luis Machado
2016-12-01 17:35 ` Pedro Alves
2016-12-01 20:52 ` Luis Machado
2016-11-28 18:57 ` [PATCH v2 0/8] Fix gdb's testsuite test names Sergio Durigan Junior
2016-11-28 19:00 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129144851.GF22209@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).