New ARI warning Thu Jan 5 01:57:29 UTC 2017

New ARI warning Thu Jan 5 01:57:29 UTC 2017

[GDB Administrator]

328a329,330
> gdb/mips-fbsd-tdep.c:335: code: OP eol: Do not use &&, or || at the end of a line
gdb/mips-fbsd-tdep.c:335:  if (target_read_memory (ucontext_addr + O32_UCONTEXT_FPUSED, buf, 4) == 0 &&
> gdb/mips-fbsd-tdep.c:427: code: OP eol: Do not use &&, or || at the end of a line
gdb/mips-fbsd-tdep.c:427:  if (target_read_memory (ucontext_addr + N64_UCONTEXT_FPUSED, buf, 4) == 0 &&

[COMMITTED] Fix ARI warning

[Yao Qi]

This patch splits the expression before the && operator instead of
after it.

gdb:

2017-01-05  Yao Qi  <yao.qi@linaro.org>

	* mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to
	new line.
	(mips64_fbsd_sigframe_init): Likewise.
---
 gdb/ChangeLog        | 6 ++++++
 gdb/mips-fbsd-tdep.c | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6f35a0f..df1f03a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2017-01-05  Yao Qi  <yao.qi@linaro.org>
+
+	* mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to
+	new line.
+	(mips64_fbsd_sigframe_init): Likewise.
+
 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
 
 	* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Use
diff --git a/gdb/mips-fbsd-tdep.c b/gdb/mips-fbsd-tdep.c
index ba8c07e..00fae0e 100644
--- a/gdb/mips-fbsd-tdep.c
+++ b/gdb/mips-fbsd-tdep.c
@@ -332,8 +332,8 @@ mips_fbsd_sigframe_init (const struct tramp_frame *self,
 			   regnum + gdbarch_num_regs (gdbarch),
 			   ucontext_addr + O32_UCONTEXT_HI);
 
-  if (target_read_memory (ucontext_addr + O32_UCONTEXT_FPUSED, buf, 4) == 0 &&
-      extract_unsigned_integer (buf, 4, byte_order) != 0)
+  if (target_read_memory (ucontext_addr + O32_UCONTEXT_FPUSED, buf, 4) == 0
+      && extract_unsigned_integer (buf, 4, byte_order) != 0)
     {
       for (regnum = 0, addr = ucontext_addr + O32_UCONTEXT_FPREGS;
 	   regnum < 32; regnum++, addr += O32_UCONTEXT_REG_SIZE)
@@ -424,8 +424,8 @@ mips64_fbsd_sigframe_init (const struct tramp_frame *self,
 			   regnum + gdbarch_num_regs (gdbarch),
 			   ucontext_addr + N64_UCONTEXT_HI);
 
-  if (target_read_memory (ucontext_addr + N64_UCONTEXT_FPUSED, buf, 4) == 0 &&
-      extract_unsigned_integer (buf, 4, byte_order) != 0)
+  if (target_read_memory (ucontext_addr + N64_UCONTEXT_FPUSED, buf, 4) == 0
+      && extract_unsigned_integer (buf, 4, byte_order) != 0)
     {
       for (regnum = 0, addr = ucontext_addr + N64_UCONTEXT_FPREGS;
 	   regnum < 32; regnum++, addr += N64_UCONTEXT_REG_SIZE)
-- 
1.9.1