From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86646 invoked by alias); 18 Jan 2017 08:57:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86617 invoked by uid 89); 18 Jan 2017 08:57:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hayward, hayward, sk:alan.ha, alanhaywardarmcom X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jan 2017 08:56:53 +0000 Received: by mail-wm0-f65.google.com with SMTP id c85so2435178wmi.1 for ; Wed, 18 Jan 2017 00:56:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QWBdauvD8hllwZEI+SbzmMXs3ugWJo/BmDQKRcVGk80=; b=UZ+pW720LSvuBFEPF85JhoHcIP6U1SaBaCxDGQtnx7HujzUhXHuU9EaEt4iQBLQTH8 mdJNyYqrUae44G0R7x5yNWzXDJMpdHNPT1WjqcC00wSUTps533R52XuNLai5uHJZM0tn atA7wT55oNvxdSj+Hf/8lHsXM9/w/9J74XMNEuYGq2flf6RB7SWVyYc47sLTyXDGs4fL Ax9FGB0xqXCTinXrD+1NtoqloJ+CIGKdNk9mwdLr3sIUK5cH2S56F/vLdyUaMrXHBUh7 wIQfvKYvNGFxLWE82QlOAD/UzxrMk1oipE/ugb7eukhMc6t7hFCIbZUcbpA5tkr2L7sk 0Jig== X-Gm-Message-State: AIkVDXIHSPzuFsqBW4SkbgAxv5H7iMQ0nBZthbnd8uEUJkzq5sTbag7PoazQg0AoCQrByw== X-Received: by 10.28.157.201 with SMTP id g192mr1725709wme.29.1484729811068; Wed, 18 Jan 2017 00:56:51 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id x135sm3244827wme.23.2017.01.18.00.56.48 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 18 Jan 2017 00:56:50 -0800 (PST) Date: Wed, 18 Jan 2017 08:57:00 -0000 From: Yao Qi To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 1/3] Use register_size () instead of MAX_REGISTER_SIZE Message-ID: <20170118085634.GK28060@E107787-LIN> References: <902F747B-B822-4629-8DB8-D6775357E6A5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <902F747B-B822-4629-8DB8-D6775357E6A5@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00338.txt.bz2 On 17-01-09 10:55:18, Alan Hayward wrote: > Aarch64 SVE requires a max register size of 256. The current max size in gdb > is 64. This is part of a series demonstrating the replacement of > MAX_REGISTER_SIZE. > > In cases where a buffer is created to hold a single register, then > MAX_REGISTER_SIZE can be replaced with a call to register_size (). > > This patch is restricted to amd64-tdep.c, remote.c and regcache.c. > Follow on patch sets will expand to other files. > > Tested on x86. > Ok to commit? > > Thanks, > Alan. > Nits on ChangeLog, > 2017-01-09 Alan Hayward two spaces between date and name. > > * amd64-tdep.c (amd64_pseudo_register_read_value): remove ^^^^^ tab rather than spaces. > MAX_REGISTER_SIZE. * amd64-tdep.c (amd64_pseudo_register_read_value): Use register_size instead of MAX_REGISTER_SIZE. > (amd64_pseudo_register_read_value): Likewise. > * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE. > (store_register_using_P): Likewise. > * regcache.c (regcache_xfer_part): Likewise. otherwise, patch is good to me. -- Yao (齐尧)