From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112620 invoked by alias); 19 Feb 2017 21:26:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112609 invoked by uid 89); 19 Feb 2017 21:26:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Feb 2017 21:26:57 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BA1F37E64; Sun, 19 Feb 2017 21:26:57 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50FC82D5EB; Sun, 19 Feb 2017 21:26:56 +0000 (UTC) Date: Sun, 19 Feb 2017 21:26:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Victor Leschuk Subject: Re: [PATCH 8/8] DWARF-5: DW_FORM_data16 Message-ID: <20170219212652.GE1291@host1.jankratochvil.net> References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <148693102336.9024.6339944981062939536.stgit@host1.jankratochvil.net> <3bfb48f9-168a-26ae-678b-92b059583c4e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bfb48f9-168a-26ae-678b-92b059583c4e@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00523.txt.bz2 On Fri, 17 Feb 2017 13:09:42 +0100, Pedro Alves wrote: > On 02/12/2017 08:23 PM, Jan Kratochvil wrote: > > > @@ -20250,6 +20261,10 @@ dump_die_shallow (struct ui_file *f, int indent, struct die_info *die) > > fprintf_unfiltered (f, "expression: size %s", > > pulongest (DW_BLOCK (&die->attrs[i])->size)); > > break; > > + case DW_FORM_data16: > > + /* FIXME: Print the contents. */ > > + fprintf_unfiltered (f, "constant of 16 bytes"); > > Should we fix that FIXME? I think even the code above "expression: size %s" should print the contents which it does not and it has no FIXME there. So I have just removed the FIXME. Jan