From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40020 invoked by alias); 11 May 2017 21:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39995 invoked by uid 89); 11 May 2017 21:03:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*jhb, H*r:100, thursday, treatment X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 21:03:40 +0000 Received: by mail-wm0-f68.google.com with SMTP id v4so9634548wmb.2 for ; Thu, 11 May 2017 14:03:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sUa56xvbXTxCwBVJkekb2oDpixJ3ZLnS02f4HE+M+88=; b=ZU0GEiRM3tjJ0OQtoJjr6cdRIDZaVxeZXiOA3KKWtIvdy8kfFnsD++2S4wJ54Zm8AX owPQamha8HwQycR5/grfCeVjZuhAp+JaHOBgaKLWNAZDGvdEDbNTolX89bo0jX8NHms4 hGe1yD8JLJ53rZhQsyBpFuWwtgFOc2/w5jAx8RGHVDPRTC6xwdEDimPOfHbs9uKh4rZX jY7MuBxmPxdJHv3B49B+OcALb5FTkWVIWTwvCpV6Ie7HCCmYCT19+KfWGZXZ93fKvvrg QCKizNkvUN6+cLDAjRxhKPh7zSD/UDumRbMCLt6c5PHTUke9ROz8K45tlWmeaMCAI+Pa j2Ag== X-Gm-Message-State: AODbwcAL0hKWMkKnlyeMPQZSaH5P99RjmvDAGO+xwabFgCvqMJjKm0AJ cCloo3xImj38cSjJ X-Received: by 10.28.111.130 with SMTP id c2mr26538wmi.77.1494536621272; Thu, 11 May 2017 14:03:41 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:f98c:5f75:db14:bcce]) by smtp.gmail.com with ESMTPSA id p197sm1845187wmb.34.2017.05.11.14.03.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 May 2017 14:03:40 -0700 (PDT) Date: Thu, 11 May 2017 21:03:00 -0000 From: Yao Qi To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [RFC 6/7] Lazily and dynamically create i386-linux target descriptions Message-ID: <20170511210336.uzogscsc2ynbogfc@localhost> References: <1494518105-15412-1-git-send-email-yao.qi@linaro.org> <1494518105-15412-7-git-send-email-yao.qi@linaro.org> <5290733.2saQ3BOrGQ@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5290733.2saQ3BOrGQ@ralph.baldwin.cx> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00301.txt.bz2 On 17-05-11 10:04:39, John Baldwin wrote: > On Thursday, May 11, 2017 04:55:04 PM Yao Qi wrote: > > Instead of using pre-generated target descriptions, this patch > > changes GDB to lazily and dynamically create target descriptions > > according to the target hardware capability (xcr0 in i386). > > This support any combination of target features. > > > > This patch also adds a unit test to make sure dynamically generated > > tdesc are identical to these generated from xml files. > > I definitely like this approach of composing the tdesc. For the > non-Linux case there are already amd64_target_description() and > i386_target_description() functions in the respective -tdep.c files > that could use the same treatment. Not sure if you wanted to fix all > of x86 in the same patch series or do it as a separate followup? > The later, but I can fix all x86 in one patch if people think it is more reasonable to do so. I plan to change one arch each time, and gradually change all archs to use the new style of target description. -- Yao