From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42141 invoked by alias); 11 May 2017 21:29:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41751 invoked by uid 89); 11 May 2017 21:29:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:100 X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 21:29:12 +0000 Received: by mail-wm0-f52.google.com with SMTP id b84so1278107wmh.0 for ; Thu, 11 May 2017 14:29:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F1rssAJwFROuHuapXdGQCj4t5kSNoQ4exjxfRNaHQ5E=; b=WsU+hSWtvYAoSkQlN7CFCWX5T4yRhrZT2jYiMFjlXzrw/aqsbGeYcr6X2+cKv30nC0 NBq5FoWpaVRUlqkg2tawzfgH2UvyRx4ji8q6LB3Xl67SDCol4aUJwdgjz/j6CzZGtoRe Rxw6Qz8wG6Fd99oXypmaw4b+ScBHwZsz3gh8U/SS4UuoE+OGcywId7TYQpcZEDQF2Fmw 376iy9+13CLypAY9RqOCDZZJE5g6PqsgwNDb6H6erK5TKnlwjwnFYSeoEelV6ui8BmEd nnYWDG+pMObfnxrNPoAGFyJRrj7rkM9jx32WCDIiDSHRWf6o5ZVoNQmurlvBCEiUVujN c/DA== X-Gm-Message-State: AODbwcBO5/9Tj7UoWjWC/dOGWj8/7Y/ufqj51XZJb08zmpW4FQInlKuM /m2gJho7DZtKX+2/ X-Received: by 10.28.126.202 with SMTP id z193mr83128wmc.141.1494538153478; Thu, 11 May 2017 14:29:13 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:f98c:5f75:db14:bcce]) by smtp.gmail.com with ESMTPSA id j126sm2099173wmd.29.2017.05.11.14.29.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 May 2017 14:29:13 -0700 (PDT) Date: Thu, 11 May 2017 21:29:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 04/19] Remove addr_size field from struct piece_closure Message-ID: <20170511212908.d4yys2qhzn377tia@localhost> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-5-git-send-email-arnez@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494352015-10465-5-git-send-email-arnez@linux.vnet.ibm.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00305.txt.bz2 On 17-05-09 19:46:00, Andreas Arnez wrote: > The addr_size field in the piece_closure data structure is a relic from > before introducing the typed DWARF stack. It is obsolete now. This patch > removes it. > > gdb/ChangeLog: > > * dwarf2loc.c (struct piece_closure) : Remove field. > (allocate_piece_closure): Drop addr_size parameter. > (dwarf2_evaluate_loc_desc_full): Adjust call to > allocate_piece_closure. It is obvious, patch is good to me. -- Yao