public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
Date: Thu, 08 Jun 2017 05:01:00 -0000	[thread overview]
Message-ID: <20170608050151.GB5971@lianli.shorne-pla.net> (raw)
In-Reply-To: <83d1af8an1.fsf@gnu.org>

On Thu, Jun 08, 2017 at 05:40:34AM +0300, Eli Zaretskii wrote:
> > From: Stafford Horne <shorne@gmail.com>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Date: Thu,  8 Jun 2017 07:15:47 +0900
> > 
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,10 @@
> >  
> >  *** Changes since GDB 8.0
> >  
> > +* GDB now supports dynamically creating arbitrary register groups specified
> > +  in xml target descriptors.  This allows for finer grain grouping of
> > +  registers on systems with a large amount of registers.
> > +
> 
> I'm confused: in the commentary for the patch to the manual you said
> the feature existed, but wasn't documented.  So why is it mentioned in
> NEWS as a new feature?  Should we have more documentation changes, if
> it's new?

Thanks for reviewing.

Sorry, you are right its a bit confusing and this second part probably
needs some more document changes.

There are 2 things going on in those 2 patches.
  1. Add docs for the existing feature (listing registers by group name)
  2. Add feature to be able to defined more groups based on the XML target
     description.

Ill add docs for (2) and try to make it a bit more clear in my next cover
letter.

Is the single NEWS entry ok in the end?

-Stafford

  reply	other threads:[~2017-06-08  5:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 22:15 [PATCH 0/3] Support for arbitrary reggroups Stafford Horne
2017-06-07 22:16 ` [PATCH 3/3] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-06-08  2:40   ` Eli Zaretskii
2017-06-08  5:01     ` Stafford Horne [this message]
2017-06-08 14:56       ` Eli Zaretskii
2017-06-08 20:52   ` Simon Marchi
2017-06-09 11:45     ` Stafford Horne
2017-06-09 19:59       ` Simon Marchi
2017-06-10  8:17         ` Stafford Horne
2017-06-13 11:17   ` Pedro Alves
2017-06-07 22:16 ` [PATCH 2/3] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-06-07 22:16 ` [PATCH 1/3] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-06-08  2:38   ` Eli Zaretskii
2017-06-08  4:59     ` Stafford Horne
2017-06-08 20:31   ` Simon Marchi
2017-06-08 23:27     ` Stafford Horne
2017-06-09  6:20       ` Simon Marchi
2017-06-13 11:17   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608050151.GB5971@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).