Re: [PATCH] gdb: Unset PROMPT_COMMAND before testing

[Andrew Burgess <andrew.burgess@embecosm.com>]

* Yao Qi <qiyaoltc@gmail.com> [2017-06-22 11:12:02 +0100]:

> Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> > One of the GDB tests starts up a sub-shell and runs a few commands in
> > it.  In some cases, a users PROMPT_COMMAND might not work in the
> > sub-shell GDB starts, which could cause the shell to emit unexpected
> > warnings or errors, this in turn could cause tests to fail.
> 
> What is the concrete output in your case?
> 
> >
> > The current example is gdb.base/batch-preserve-term-settings.exp, but
> > there could be others in the future.
> >
> > I don't see any regressions with this patch, but I do now see 5
> > additional passes on gdb.base/batch-preserve-term-settings.exp.
> 
> This patch sets the env for build rather than host, so it doesn't help
> in remote host.  Note that I don't think DejaGNU can set env in remote.

Thank you for taking the time to look at this patch, but after reading
your feedback and further consideration I now realise that this issue
should really be fixed at my end.

Apologies for wasting your time, and the mailing list noise.

Thanks,
Andrew