From: Jerome Guitton <guitton@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR cli/21688: Fix multi-line/inline command differentiation
Date: Thu, 29 Jun 2017 12:51:00 -0000 [thread overview]
Message-ID: <20170629125059.GG24541@adacore.com> (raw)
In-Reply-To: <20170629020527.468-1-sergiodj@redhat.com>
Sergio Durigan Junior (sergiodj@redhat.com):
> The problem happens because, on cli/cli-script.c:process_next_line,
> GDB is not using the command line string to identify which command to
> run, but it instead using the 'struct cmd_list_element *' that is
> obtained by using the mentioned string. The problem with that is that
> the 'struct cmd_list_element *' doesn't have any information on
> whether the command issued by the user is a multi-line or inline one.
Indeed. Thank you for catching this bug!
next prev parent reply other threads:[~2017-06-29 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 2:05 Sergio Durigan Junior
2017-06-29 12:51 ` Jerome Guitton [this message]
2017-06-29 19:08 ` Simon Marchi
2017-06-29 19:48 ` Sergio Durigan Junior
2017-06-29 21:06 ` Simon Marchi
2017-06-29 22:21 ` Sergio Durigan Junior
2017-06-30 7:01 ` Simon Marchi
2017-06-30 11:16 ` Sergio Durigan Junior
2017-06-30 11:14 ` Pedro Alves
2017-06-30 11:24 ` Sergio Durigan Junior
2017-06-30 11:30 ` Pedro Alves
2017-06-30 12:33 ` Sergio Durigan Junior
2017-06-30 12:34 ` [PATCH] PR cli/21688: Detect aliases when issuing python/compile/guile commands (and fix last commit) Sergio Durigan Junior
2017-06-30 13:02 ` Pedro Alves
2017-06-30 13:33 ` Sergio Durigan Junior
2017-06-30 13:49 ` Pedro Alves
2017-06-30 13:51 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629125059.GG24541@adacore.com \
--to=guitton@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).