From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
Date: Thu, 05 Oct 2017 16:50:00 -0000 [thread overview]
Message-ID: <20171005165012.0528CD835F0@oc3748833570.ibm.com> (raw)
In-Reply-To: <1506957311-30028-4-git-send-email-palves@redhat.com> from "Pedro Alves" at Oct 02, 2017 04:15:11 PM
Pedro Alves wrote:
> * target.c (default_thread_architecture): Use the sepecified
> inferior's architecture, instead of the current inferior's
> architecture (via target_gdbarch).
This causes a number of ICEs in the test suite for me, at the point when
default_thread_architecture is called from linux_child_follow_fork here:
if (!gdbarch_software_single_step_p (target_thread_architecture
(child_lp->ptid)))
Note that at this point there is no inferior for the child, and I think
there will never be one since the child is to be detached immediately.
Given that this is a fork, I guess a simple fix would be to check
for the parent's thread architecture here instead.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2017-10-05 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 15:15 [PATCH 0/3] " Pedro Alves
2017-10-02 15:15 ` [PATCH 2/3] Reimplement support for "maint print registers" with no running inferior yet Pedro Alves
2017-10-03 11:17 ` Yao Qi
2017-10-02 15:15 ` [PATCH 1/3] Redesign mock environment for gdbarch selftests Pedro Alves
2017-10-03 11:06 ` Yao Qi
2017-10-03 12:05 ` Pedro Alves
2017-10-04 10:39 ` Yao Qi
2017-10-02 15:15 ` [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors Pedro Alves
2017-10-03 11:36 ` Yao Qi
2017-10-03 11:40 ` Yao Qi
2017-10-03 12:21 ` Pedro Alves
2017-10-03 14:02 ` Pedro Alves
2017-10-04 10:21 ` Yao Qi
2017-10-04 17:38 ` Pedro Alves
2017-10-05 16:50 ` Ulrich Weigand [this message]
2017-10-05 17:08 ` Pedro Alves
2017-12-12 21:33 ` Maciej W. Rozycki
2017-12-13 0:45 ` Pedro Alves
2017-12-13 11:31 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005165012.0528CD835F0@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).